Skip to content

Don't run large_serializable in PR #8549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2024
Merged

Don't run large_serializable in PR #8549

merged 2 commits into from
Aug 30, 2024

Conversation

@maximyurchuk
Copy link
Collaborator

@maximyurchuk maximyurchuk commented Aug 30, 2024 •
edited
Loading

Changelog entry

It is useless to run on PRs, because of

  • retries
  • it takes too long (10 min)
  • too flaky
  • also enlarge timeout

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

gridnevvvit
gridnevvvit previously approved these changes Aug 30, 2024
View reviewed changes
@maximyurchuk maximyurchuk marked this pull request as ready for review August 30, 2024 15:35
@gridnevvvit gridnevvvit self-requested a review August 30, 2024 15:35
@github-actions
Copy link

github-actions bot commented Aug 30, 2024 •
edited
Loading

⚪ 2024-08-30 15:42:13 UTC Pre-commit check linux-x86_64-release-asan for 92d4e51 has started.
⚪ 2024-08-30 15:45:30 UTC ya make is running...
🟢 2024-08-30 15:45:35 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-08-30 15:45:43 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 30, 2024 •
edited
Loading

⚪ 2024-08-30 15:42:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for 92d4e51 has started.
⚪ 2024-08-30 15:45:30 UTC ya make is running...
🟢 2024-08-30 15:45:35 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-08-30 15:45:42 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 30, 2024 •
edited
Loading

⚪ 2024-08-30 15:43:40 UTC Pre-commit check linux-x86_64-release-clang14 for 92d4e51 has started.
⚪ 2024-08-30 15:46:17 UTC ya make is running...
🟢 2024-08-30 15:46:25 UTC Build successful.

@maximyurchuk maximyurchuk merged commit 55c87c9 into ydb-platform:main Aug 30, 2024
maximyurchuk added a commit that referenced this pull request Aug 30, 2024
@maximyurchuk
Revert "Don't run large_serializable in PR (#8549)"
91e89bd 
This reverts commit 55c87c9.
This was referenced Sep 2, 2024
Merged
Merged
@siarheivesialou siarheivesialou mentioned this pull request Sep 4, 2024
Merged
This was referenced Sep 4, 2024
Merged
Merged
Merged
This was referenced Sep 9, 2024
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gridnevvvit gridnevvvit gridnevvvit approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maximyurchuk @gridnevvvit