Do not ignore configure errors #8586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
not-for-changelog
and removed
new-feature
not-for-changelog
labels
nikitka
approved these changes
Sep 2, 2024
KirillKurdyukov
pushed a commit
to KirillKurdyukov/ydb
that referenced
this pull request
Sep 4, 2024
This was referenced Sep 4, 2024
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog entry
Do not mask configure errors
The problem is in script
https://github.com/ydb-platform/ydb/blob/1af55dfd2469751be894c4db2a0c692905595490/.github/scripts/graph_compare.sh
It uses
ya make ... -kswitch which hides configure errorsSee YA-1456 and yandex/yatool#7 for details
Changelog category
Additional information
Original problem was in
#8549
#8560