Skip to content

-o pipefail in graph_compare #8600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2024
Merged

-o pipefail in graph_compare #8600

merged 1 commit into from
Sep 2, 2024

Conversation

@maximyurchuk
Copy link
Collaborator

@maximyurchuk maximyurchuk commented Sep 2, 2024 •
edited
Loading

Changelog entry

Do not ignore ya make errors in graph_compare

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Original problem was in
#8549
#8560

@maximyurchuk maximyurchuk marked this pull request as ready for review September 2, 2024 10:38
@github-actions
Copy link

github-actions bot commented Sep 2, 2024 •
edited
Loading

⚪ 2024-09-02 10:49:00 UTC Pre-commit check linux-x86_64-release-clang14 for 1a415fc has started.
⚪ 2024-09-02 10:51:21 UTC ya make is running...
🟢 2024-09-02 10:51:28 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 2, 2024 •
edited
Loading

⚪ 2024-09-02 11:02:06 UTC Pre-commit check linux-x86_64-release-asan for 1a415fc has started.
⚪ 2024-09-02 11:04:18 UTC ya make is running...
🟢 2024-09-02 11:04:22 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-09-02 11:04:28 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Sep 2, 2024 •
edited
Loading

⚪ 2024-09-02 11:09:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1a415fc has started.
⚪ 2024-09-02 11:12:21 UTC ya make is running...
🟢 2024-09-02 11:12:26 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-09-02 11:12:32 UTC Build successful.

@maximyurchuk maximyurchuk merged commit 693fe60 into ydb-platform:main Sep 2, 2024
KirillKurdyukov pushed a commit to KirillKurdyukov/ydb that referenced this pull request Sep 4, 2024
@maximyurchuk @KirillKurdyukov
-o pipefail in graph_compare (ydb-platform#8600)
86184ce
@siarheivesialou siarheivesialou mentioned this pull request Sep 4, 2024
Merged
This was referenced Sep 4, 2024
Merged
Merged
Merged
This was referenced Sep 9, 2024
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikitka nikitka nikitka approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maximyurchuk @nikitka