Skip to content

(refactoring) Split TEvChangeExchange into two parts: common & DS KIKIMR-20673 #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2024
Merged

(refactoring) Split TEvChangeExchange into two parts: common & DS KIKIMR-20673 #1152

merged 1 commit into from
Jan 19, 2024

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Jan 19, 2024 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@CyberROFL CyberROFL requested a review from Enjection January 19, 2024 10:54
@CyberROFL CyberROFL marked this pull request as ready for review January 19, 2024 10:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 19, 2024 •
edited
Loading

⚪ 2024-01-19 11:51:34 UTC Pre-commit check for 0d8b054 has started.
⚪ 2024-01-19 11:51:36 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-01-19 11:54:09 UTC Build failed. see the build logs.
⚪ 2024-01-19 11:54:19 UTC Tests are running...
🔴 2024-01-19 13:09:29 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59984 50736 0 4 9231 13

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 19, 2024 •
edited
Loading

⚪ 2024-01-19 11:52:10 UTC Pre-commit check for 0d8b054 has started.
⚪ 2024-01-19 11:52:13 UTC Build linux-x86_64-release-asan is running...
🔴 2024-01-19 11:54:55 UTC Build failed. see the build logs.
⚪ 2024-01-19 11:55:08 UTC Tests are running...
🔴 2024-01-19 13:31:43 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15888 15774 0 37 65 12

Enjection
Enjection requested changes Jan 19, 2024
View reviewed changes
Copy link
Member

@Enjection Enjection left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, PR seems okay, but perturbations involving event id's look dangerous.

@CyberROFL CyberROFL force-pushed the KIKIMR-20673/split-change-exchange branch from a46988a to 0d8b054 Compare January 19, 2024 11:49
@CyberROFL CyberROFL merged commit e7c25d2 into ydb-platform:main Jan 19, 2024
@CyberROFL CyberROFL deleted the KIKIMR-20673/split-change-exchange branch January 19, 2024 15:18
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 24, 2024
Merged
@FloatingCrowbar FloatingCrowbar mentioned this pull request Jan 24, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 25, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 25, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Jan 25, 2024
Merged
This was referenced Jan 25, 2024
Merged
Merged
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 29, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 29, 2024
Merged
@shnikd shnikd mentioned this pull request Jan 29, 2024
Merged
This was referenced Jan 29, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 29, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 29, 2024
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 5, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 5, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 6, 2024
Closed
Merged
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
This was referenced Feb 12, 2024
Merged
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enjection Enjection Enjection approved these changes

Assignees
No one assigned
Labels
new-feature not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CyberROFL @Enjection