KIKIMR-20009: fix race condition on blobs removing #1118
Conversation
|
⚪
|
|
⚪
|
| @@ -90,7 +90,8 @@ class IBlobManager { | |||
| } | |||
|
|
|||
| // Deletes the blob that was previously permanently saved | |||
There was a problem hiding this comment.
It seems to me that comment relates to old DeleteBlob and we can write new comments for DeleteBlobOnExecute and DeleteBlobOnComplete (prefer) or remove old comment.
| @@ -64,12 +64,12 @@ class TStorageAction { | |||
| } | |||
| } | |||
|
|
|||
| void OnCompleteTxAfterAction(NColumnShard::TColumnShard& self) { | |||
| void OnCompleteTxAfterAction(NColumnShard::TColumnShard& self, const bool success) { | |||
There was a problem hiding this comment.
nit:
I see that Ev->Get()->GetPutStatus() is passing result to success.
I suggest considering the possibility of naming the variable not success but specifying the success of which operation is expected here.
Changelog entry
split actions:
on execute we have to write into db only
on complete we have to write to memory storage
in other way we have problem in case execution not finished, but gc finished before and if binary killed in this time, we have problem with meta withno blobs
Changelog category
Additional information
...