Skip to content

Handle invalid base #11075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2024
Merged

Handle invalid base #11075

merged 2 commits into from
Oct 30, 2024

Conversation

@vitstn
Copy link
Collaborator

@vitstn vitstn commented Oct 29, 2024

Changelog entry

...

Changelog category

  • Bugfix

Additional information

...

@vitstn vitstn requested a review from a team as a code owner October 29, 2024 17:11
@vitstn vitstn added the area/yql YQL query language issues label Oct 29, 2024
@github-actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

⚪ 2024-10-29 17:15:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for 685c6d9 has started.
⚪ 2024-10-29 17:15:30 UTC Artifacts will be uploaded here
⚪ 2024-10-29 17:18:10 UTC ya make is running...
⚫ 2024-10-29 17:33:18 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

⚪ 2024-10-29 17:15:22 UTC Pre-commit check linux-x86_64-release-asan for 685c6d9 has started.
⚪ 2024-10-29 17:15:33 UTC Artifacts will be uploaded here
⚪ 2024-10-29 17:18:11 UTC ya make is running...
⚫ 2024-10-29 17:33:19 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

⚪ 2024-10-29 17:36:18 UTC Pre-commit check linux-x86_64-release-asan for d5abbe1 has started.
⚪ 2024-10-29 17:37:12 UTC Artifacts will be uploaded here
⚪ 2024-10-29 17:39:56 UTC ya make is running...
🟡 2024-10-29 18:10:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1763 1724 0 12 18 9

🟢 2024-10-29 18:10:41 UTC Build successful.
🟢 2024-10-29 18:10:57 UTC ydbd size 5.7 GiB changed* by +80 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 08f5064 merge: d5abbe1 diff diff %
ydbd size 6 147 831 152 Bytes 6 147 831 232 Bytes +80 Bytes +0.000%
ydbd stripped size 1 534 205 968 Bytes 1 534 205 968 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

⚪ 2024-10-29 17:36:28 UTC Pre-commit check linux-x86_64-relwithdebinfo for d5abbe1 has started.
⚪ 2024-10-29 17:37:07 UTC Artifacts will be uploaded here
⚪ 2024-10-29 17:40:15 UTC ya make is running...
🟢 2024-10-29 18:20:17 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59271 45701 0 0 13494 76

🟢 2024-10-29 18:25:33 UTC Build successful.
🟢 2024-10-29 18:25:44 UTC ydbd size 2.8 GiB changed* by +112 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 08f5064 merge: d5abbe1 diff diff %
ydbd size 3 038 244 440 Bytes 3 038 244 552 Bytes +112 Bytes +0.000%
ydbd stripped size 481 263 544 Bytes 481 263 544 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vitstn vitstn enabled auto-merge (squash) October 29, 2024 18:35
igormunkin
igormunkin approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@igormunkin igormunkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitstn, thanks for the patch! LGTM.

@vitstn vitstn merged commit e3bfd65 into ydb-platform:main Oct 30, 2024
10 checks passed
@vitstn vitstn deleted the fixed_unicode_udf branch October 30, 2024 05:08
vitstn added a commit to vitstn/ydb that referenced this pull request Oct 30, 2024
@vitstn
Handle invalid base (ydb-platform#11075)
0f33d7e
vitstn added a commit that referenced this pull request Oct 30, 2024
@vitstn
Backport #11075 (#11086)
508b66c
@GrigoriyPA GrigoriyPA mentioned this pull request Oct 31, 2024
Merged
This was referenced Nov 1, 2024
Open
Merged
@shnikd shnikd mentioned this pull request Nov 7, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Nov 8, 2024
Merged
robot-piglet pushed a commit that referenced this pull request Nov 12, 2024
@nepal
Merge PR #10831, #11068, #11075, #11152
10eb11d 
#11152 - Allow to choose normal or aggreation PG function

#11075 - Handle invalid base

#11068 - Allow more postgis functions

#10831 - Views: if exists / if not exists for DDL
commit_hash:0ebf35e45ac6de147c9000440ca25237db061d2e
maximyurchuk pushed a commit that referenced this pull request Nov 12, 2024
@nepal @maximyurchuk
Merge PR #10831, #11068, #11075, #11152
06791fb 
#11152 - Allow to choose normal or aggreation PG function

#11075 - Handle invalid base

#11068 - Allow more postgis functions

#10831 - Views: if exists / if not exists for DDL
commit_hash:0ebf35e45ac6de147c9000440ca25237db061d2e
This was referenced Nov 13, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igormunkin igormunkin igormunkin approved these changes

Assignees

No one assigned

Labels

area/yql YQL query language issues bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vitstn @igormunkin