Skip to content

Handle invalid base #11075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Handle invalid base #11075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85c993a
init
vitstn Oct 29, 2024
acb4504
test
vitstn Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ydb/library/yql/udfs/common/unicode_base/lib/unicode_base_udf.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,10 @@ namespace {
const int base = static_cast<int>(args[1].GetOrDefault<ui16>(0));
char* pos = nullptr;
unsigned long long res = std::strtoull(input, &pos, base);
if (!res && errno == EINVAL) {
UdfTerminate("Incorrect base");
}

ui64 ret = static_cast<ui64>(res);
if (!res && pos == input) {
UdfTerminate("Input string is not a number");
Expand All @@ -125,6 +129,10 @@ namespace {
const int base = static_cast<int>(args[1].GetOrDefault<ui16>(0));
char* pos = nullptr;
unsigned long long res = std::strtoull(input, &pos, base);
if (!res && errno == EINVAL) {
return TUnboxedValuePod();
}

ui64 ret = static_cast<ui64>(res);
if (!res && pos == input) {
return TUnboxedValuePod();
Expand Down
5 changes: 5 additions & 0 deletions ydb/library/yql/udfs/common/unicode_base/test/canondata/result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@
"uri": "file://test.test_ToUint64F2_/extracted"
}
],
"test.test[ToUint64F3]": [
{
"uri": "file://test.test_ToUint64F3_/extracted"
}
],
"test.test[ToUint64]": [
{
"uri": "file://test.test_ToUint64_/results.txt"
Expand Down
8 changes: 8 additions & 0 deletions ydb/library/yql/udfs/common/unicode_base/test/canondata/test.test_ToUint64F3_/extracted
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<tmp_path>/program.sql:<main>: Fatal: Execution

<tmp_path>/program.sql:<main>:2:1: Fatal: Execution of node: Result
SELECT
^
<tmp_path>/program.sql:<main>:2:1: Fatal: Incorrect base
SELECT
^
29 changes: 29 additions & 0 deletions ydb/library/yql/udfs/common/unicode_base/test/canondata/test.test_TryToUint64_/results.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,35 @@
}
]
};
{
"Write" = [
{
"Type" = [
"ListType";
[
"StructType";
[
[
"column0";
[
"OptionalType";
[
"DataType";
"Uint64"
]
]
]
]
]
];
"Data" = [
[
#
]
]
}
]
};
{
"Write" = [
{
Expand Down
2 changes: 2 additions & 0 deletions ydb/library/yql/udfs/common/unicode_base/test/cases/ToUint64F3.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
xfail

3 changes: 3 additions & 0 deletions ydb/library/yql/udfs/common/unicode_base/test/cases/ToUint64F3.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
SELECT
Unicode::ToUint64("0",1);

3 changes: 3 additions & 0 deletions ydb/library/yql/udfs/common/unicode_base/test/cases/TryToUint64.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ SELECT
SELECT
Unicode::TryToUint64("0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF", 16);

SELECT
Unicode::TryToUint64("0", 1);

SELECT
Unicode::TryToUint64("0x1234abcd", 16),
Unicode::TryToUint64("0X4", 16),
Expand Down
Loading