Handle invalid base (#11075)

Author: vitstn

ydb/library/yql/udfs/common/unicode_base/lib/unicode_base_udf.h

@@ -107,6 +107,10 @@ namespace {
         const int base = static_cast<int>(args[1].GetOrDefault<ui16>(0));
         char* pos = nullptr;
         unsigned long long res = std::strtoull(input, &pos, base);
+        if (!res && errno == EINVAL) {
+            UdfTerminate("Incorrect base");
+        }
+        
         ui64 ret = static_cast<ui64>(res);
         if (!res && pos == input) {
             UdfTerminate("Input string is not a number");
@@ -125,6 +129,10 @@ namespace {
         const int base = static_cast<int>(args[1].GetOrDefault<ui16>(0));
         char* pos = nullptr;
         unsigned long long res = std::strtoull(input, &pos, base);
+        if (!res && errno == EINVAL) {
+            return TUnboxedValuePod();
+        }
+
         ui64 ret = static_cast<ui64>(res);
         if (!res && pos == input) {
             return TUnboxedValuePod();

ydb/library/yql/udfs/common/unicode_base/test/canondata/result.json

@@ -44,6 +44,11 @@
             "uri": "file://test.test_ToUint64F2_/extracted"
         }
     ],
+    "test.test[ToUint64F3]": [
+        {
+            "uri": "file://test.test_ToUint64F3_/extracted"
+        }
+    ],
     "test.test[ToUint64]": [
         {
             "uri": "file://test.test_ToUint64_/results.txt"

ydb/library/yql/udfs/common/unicode_base/test/canondata/test.test_ToUint64F3_/extracted

@@ -0,0 +1,8 @@
+<tmp_path>/program.sql:<main>: Fatal: Execution
+
+    <tmp_path>/program.sql:<main>:2:1: Fatal: Execution of node: Result
+    	SELECT
+	^
+        <tmp_path>/program.sql:<main>:2:1: Fatal: Incorrect base
+        	SELECT
+	^

ydb/library/yql/udfs/common/unicode_base/test/canondata/test.test_TryToUint64_/results.txt

@@ -86,6 +86,35 @@
             }
         ]
     };
+    {
+        "Write" = [
+            {
+                "Type" = [
+                    "ListType";
+                    [
+                        "StructType";
+                        [
+                            [
+                                "column0";
+                                [
+                                    "OptionalType";
+                                    [
+                                        "DataType";
+                                        "Uint64"
+                                    ]
+                                ]
+                            ]
+                        ]
+                    ]
+                ];
+                "Data" = [
+                    [
+                        #
+                    ]
+                ]
+            }
+        ]
+    };
     {
         "Write" = [
             {

ydb/library/yql/udfs/common/unicode_base/test/cases/ToUint64F3.cfg

@@ -0,0 +1,2 @@
+xfail
+

ydb/library/yql/udfs/common/unicode_base/test/cases/ToUint64F3.sql

@@ -0,0 +1,3 @@
+SELECT
+    Unicode::ToUint64("0",1);
+

ydb/library/yql/udfs/common/unicode_base/test/cases/TryToUint64.sql

@@ -7,6 +7,9 @@ SELECT
 SELECT
     Unicode::TryToUint64("0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF", 16);
 
+SELECT
+    Unicode::TryToUint64("0", 1);
+
 SELECT
     Unicode::TryToUint64("0x1234abcd", 16),
     Unicode::TryToUint64("0X4", 16),