Update feature/py3 with latest master #5454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OVS command to query the state of a bond now uses the term "member" rather than "slave" for bond links. Adapt the code in networkd to expect this. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
CA-388437: fix bond status reporting
The bugfix for the CA ticket is simple, but there're issues with unittest/pylint/pytype Need more time to review. To not block the GA, just revert the python3 changes as a fix Will do the python3 porting later in a feature branch Signed-off-by: Stephen Cheng <stephen.cheng@cloud.com>
This reverts commit 4ea474b. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
This reverts commit 8a72e0f. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
This reverts commit 48c8c3e. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
This reverts commit 4140ff1. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
This makes it more convenient to feature flag any future cluster_health features (A number of them on the way, such as sending alerts). Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
…luster-health-flag Refactor cluster_health flag checking
It does not support linting actions, which blocks reusing code in github actions. On top of that it hasn't been updated in months. There's a PR to add actions to it since october. Since this is blocking xapi-project#5433, remove it Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
…nabled Signed-off-by: Steven Woods <steven.woods@citrix.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Correct mistakes on `joined` field and add more details on `destroy` message. Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
We add three new alert messages in addition to the existing `cluster_host_fencing`: `cluster_host_leaving`, `cluster_host_joining` and `cluster_quorum_approaching_lost`. The leave and join message are added whenever a host leaves the cluster, whether as a result of the user operation, or due to unexpected errors (in which case we will likely get an additional fencing alert). The approaching quorum message is sent when the cluster cannot tolerate any more loss of hosts. Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
…luster-alert CP-46324: Send alert when a host leaves/joins the cluster
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
…ement-in-rrdd.API.wait_until_next_reading
Signed-off-by: Steven Woods <steven.woods@citrix.com>
Instead delay the connection to each request. These will still fail when xapi is offline. Currently means roundtrips are done, depending on the request. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Adds: - `xs.xapi.task.id`; - `xs.xapi.task.name`; - `xs.xapi.task.uuid`; - `xs.xapi.task.session.track.id`; - `xs.xapi.task.origin`; to the list of possible attributes of spans created by `context.ml` This improves the debuggability and makes spans more easily identifiable. Signed-off-by: Gabriel Buica <danutgabriel.buica@cloud.com>
Removes code duplication by passing the exception error as an optional argument to `complete_tracing`. Improves code maitainability. Signed-off-by: Gabriel Buica <danutgabriel.buica@cloud.com>
…-46155 CP-46155: Call SM scripts via observer.py when SM observer is enabled
Adds a new variable in `Xapi_globs` that is a comma-separeted string of components. Components in this list will be considered experimental and therefore disabled by default. They can be enabled by adding an entry in `xapi.conf` without their name. For instance, adding the line: observer-experimental-components = "" will enable all experimental components. Signed-off-by: Gabriel Buica <danutgabriel.buica@cloud.com>
use xapi-guard for name in logs Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
…/CP-46157 CP:46157: Add `observer_experimental_components` flag
…/CP-46631 CP-46631: Improved list of span attributes.
This partially reverts commit 29f844c: the Java SDK defines a 'latest' API function, but 'API_2_20' enum was undefined. This fixes the Java build (we may need a different solution on API versioning of SDK languages though). Fixes: 29f844c ("CA-387698: datamodel: eliminate next_release") Signed-off-by: Edwin Török <edwin.torok@cloud.com>
Signed-off-by: Edwin Török <edwin.torok@cloud.com>
…guard CA-385323: Enable creating domain sockets while xapi isn't running
Sysfs.list_drivers is returning the list of only PCI driver, so make it clear. We want to support also USB cards so this change could avoid confusions in the future. Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
…dk-fix-java-build Xen-API Java SDK: fix the build (reintroduce 2.20 API version definition)
Make clear which drivers list we are getting
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/py3 #5454 +/- ##
===============================================
+ Coverage 45.38% 49.07% +3.68%
===============================================
Files 18 18
Lines 2937 2319 -618
===============================================
- Hits 1333 1138 -195
+ Misses 1604 1181 -423
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lindig
approved these changes
Feb 13, 2024
bernhardkaindl
approved these changes
Feb 13, 2024
pytype_reporter extracted 50 problem reports from pytype output. You can check the results of the job here |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges master branch into the python 3 feature branch for #5453 (re-take of py3 for storage-api)