CP:46157: Add observer_experimental_components flag
#5428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mg12
approved these changes
Feb 5, 2024
edwintorok
reviewed
Feb 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5428 +/- ##
=======================================
Coverage 49.07% 49.07%
=======================================
Files 18 18
Lines 2319 2319
=======================================
Hits 1138 1138
Misses 1181 1181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
psafont
reviewed
Feb 7, 2024
edwintorok
approved these changes
Feb 8, 2024
|
|
||
| let filter_out_exp_components components = | ||
| let open Xapi_globs in | ||
| let component_set = components |> List.map to_string |> StringSet.of_list in |
There was a problem hiding this comment.
We could have a set for type t instead, although I think you had problems with circular dependencies that way?
There was a problem hiding this comment.
Yes, using the custom setter to make a set of type t creates a circular dependency. Although after adding the strings to constants.ml we can validate the elements of the string set.
GabrielBuica
force-pushed
the
private/dbuica/CP-46157
branch
from
e934804 to
26020b6
Compare
Adds a new variable in `Xapi_globs` that is a comma-separeted string of components. Components in this list will be considered experimental and therefore disabled by default. They can be enabled by adding an entry in `xapi.conf` without their name. For instance, adding the line: observer-experimental-components = "" will enable all experimental components. Signed-off-by: Gabriel Buica <danutgabriel.buica@cloud.com>
GabrielBuica
force-pushed
the
private/dbuica/CP-46157
branch
from
33f587e to
ff5f954
Compare
|
Passed bvt 194450 and DT 3927437. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new variable in
Xapi_globsthat is a comma-separeted string of components. Components in this list will be considered experimental and therefore disabled by default. They can be enabled by adding an entry inxapi.confwithout their name.For instance, adding the line:
observer-experimental-components = ""
will enable all experimental copmponents.