Refactor cluster_health flag checking #5432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it more convenient to feature flag any future cluster_health features (A number of them on the way, such as sending alerts). Signed-off-by: Vincent Liu <shuntian.liu2@cloud.com>
robhoes
approved these changes
Feb 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5432 +/- ##
=======================================
Coverage 45.38% 45.38%
=======================================
Files 18 18
Lines 2937 2937
=======================================
Hits 1333 1333
Misses 1604 1604
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
psafont
approved these changes
Feb 6, 2024
pytype_reporter extracted 49 problem reports from pytype output.You can check the results of the job here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it more convenient to feature flag any future cluster_health features (A number of them on the way, such as sending alerts).