Skip to content

Conversation

@jasondaming
Copy link
Member

Summary

This PR reorganizes the existing command-based documentation into a commands-v2/ subdirectory to prepare for Commands v3 documentation. This is Phase 1 of the Commands v3 documentation project, addressing feedback from @SamCarlberg on PR #3095.

Changes

File Organization

  • Moved 12 v2 documentation files to commands-v2/ subdirectory (with git history preserved via git mv)
  • Created commands-v2/index.rst as the new landing page for Commands v2 documentation
  • Updated commandbased/index.rst to serve as a high-level framework chooser between v2 and v3

Cross-Reference Updates

  • Updated 4 internal references within v2 files to use the new commands-v2/ prefix
  • Updated 24 external files throughout the documentation to point to new v2 locations
  • Added 12 redirects in redirects.txt to ensure old URLs continue working

Files Moved

  • what-is-command-based.rst
  • commands.rst
  • command-compositions.rst
  • subsystems.rst
  • binding-commands-to-triggers.rst
  • structuring-command-based-project.rst
  • organizing-command-based.rst
  • command-scheduler.rst
  • cpp-command-discussion.rst
  • pid-subsystems-commands.rst
  • profile-subsystems-commands.rst
  • profilepid-subsystems-commands.rst

Rationale

This addresses the main concern from PR #3095 that the work was too large to review effectively. By splitting into phases:

  1. Phase 1 (this PR): Simple reorganization of existing v2 docs - easy to review
  2. Phase 2 (next PR): v3 documentation outline with TODO placeholders - review structure
  3. Phase 3 (subsequent PRs): Content filling with RLIs from verified examples - manageable chunks

Testing

  • All file moves preserve git history
  • All cross-references systematically updated
  • Redirects added for backward compatibility
  • No content changes to existing documentation

Checklist

  • File moves completed with git mv
  • New commands-v2/index.rst created
  • Main commandbased/index.rst updated
  • Internal cross-references updated
  • External cross-references updated (24 files)
  • Redirects added (12 entries)
  • CLAUDE.md excluded from commit

Related to #3095

🤖 Generated with Claude Code

sciencewhiz and others added 25 commits June 3, 2025 22:18
Made a separate workflow so it runs hours later to avoid rate limits
Changed the cable to a USB-C one as non-beta XRPs use that, and updated the Micro USB link to one that's actually available.

---------

Co-authored-by: sciencewhiz <sciencewhiz@users.noreply.github.com>
Fixes dependabot alerts
Unpin urllib3 since it's no longer maintained
Update link to AdvantageScope 2025 changes to CD post, since removed
from AdvantageScope website
Update link to Spark Max getting started
Ignore filezilla and miktex as they are blocking
Python 3.9 will be out of support soon
Update RTD to Ubuntu 22.04 since 20.04 is out of support
Appears to be unused and is unmaintained
Move all Commands v2 documentation files into a commands-v2/ subdirectory to prepare for Commands v3 documentation. This is Phase 1 of the Commands v3 documentation project.

Changes:
- Move 12 v2 documentation files to commands-v2/ subdirectory (preserving git history)
- Create new commands-v2/index.rst as landing page for v2 docs
- Update main commandbased/index.rst to serve as high-level framework chooser
- Update 24 files with corrected cross-references to new v2 locations
- Add 12 redirects to ensure old URLs continue working

This reorganization addresses feedback on PR wpilibsuite#3095 to split the work into manageable phases. The next phase will add v3 documentation structure with TODO placeholders.

Related to wpilibsuite#3095
@jasondaming jasondaming changed the base branch from main to 2027 November 13, 2025 03:53
@jasondaming
Copy link
Member Author

Closing this PR - it was created from the wrong base branch (add-oxford-commas instead of 2027). Will recreate with proper base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants