-
Notifications
You must be signed in to change notification settings - Fork 288
updated logo to include WPI full name #3086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
In wonderfully confusing fashion, the logo here is just a reference and isn't actually used anywhere (I don't think). The individual sized files in https://github.com/wpilibsuite/frc-docs/tree/main/source/_static are what are actually displayed. It looks like I was the last one to touch those, but I will admit I don't remember what process I used to generate them from the single base image. |
|
Ok, I can make the same size images manually. Thanks! |
|
Best I can tell from this code, it will always pick the 300 px version, since sizes is always 300 px. I'm thinking the height parameter is ignored, or else the aspect ratio wouldn't be correct. Thoughts @TheTripleV? |
|
The browser will pick the right image size to download. Its not always 300px. If you zoom the page in for example, it switches to 1050. The logo pics are the only ones in the repo that aren't autogenerated because they don't go through sphinx and were hardcoded in RTD's theme template. |
|
Is everything ok with the new images or do I need to change the height? |
|
The images are fine. Since they are taller, please update the height in frc-docs/source/_templates/layout.html Lines 37 to 58 in 736cd53
from 468 to 600. |
WPI is working through a rebrand to use the full name when possible. This line allows that without changing the WPILib logo