[Fix] wp ios accessibility #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dratwas
force-pushed
the
fix/wp-ios-accessibility
branch
from
df9981f to
352395c
Compare
etoledom
approved these changes
Feb 17, 2020
There was a problem hiding this comment.
Approved via WordPress/gutenberg#20267 (review)
Thank you @dratwas !
6 tasks
dratwas
force-pushed
the
fix/wp-ios-accessibility
branch
from
70a0649 to
2a1b333
Compare
dratwas
force-pushed
the
fix/wp-ios-accessibility
branch
from
2a1b333 to
ed350d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
The UI tests in WP-iOS are failing because of the
Paragraph Block 1. Empty can not be found. In this PR i added a view with accessibility label to fix that.Gutenberg PR - WordPress/gutenberg#20267
WP-iOS (just for testing) wordpress-mobile/WordPress-iOS#13481
PR submission checklist:
RELEASE-NOTES.txtif necessary.