Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/release/1.23.0' into fix/wp-ios-…
Browse files Browse the repository at this point in the history
…accessibility
  • Loading branch information
dratwas committed Feb 18, 2020
1 parent 2a1b333 commit 70a0649
Show file tree
Hide file tree
Showing 168 changed files with 2,203 additions and 11,674 deletions.
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
* New block: Button
* Add scroll support inside block picker and block settings
* [Android] Fix issue preventing correct placeholder image from displaying during image upload
* [iOS] Fix diplay of large numbers on ordered lists

1.22.0
------
Expand Down
2 changes: 1 addition & 1 deletion RNTAztecView.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ Pod::Spec.new do |s|
s.xcconfig = {'OTHER_LDFLAGS' => '-lxml2',
'HEADER_SEARCH_PATHS' => '/usr/include/libxml2'}
s.dependency 'React-Core'
s.dependency 'WordPress-Aztec-iOS', '1.15.0'
s.dependency 'WordPress-Aztec-iOS', '1.16.0'

end
2,037 changes: 1,033 additions & 1,004 deletions bundle/android/App.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/App.js.map

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -9,27 +9,32 @@
"selector": ".blocks-gallery-item",
"query": {
"url": {
"type": "string",
"source": "attribute",
"selector": "img",
"attribute": "src"
},
"fullUrl": {
"type": "string",
"source": "attribute",
"selector": "img",
"attribute": "data-full-url"
},
"link": {
"type": "string",
"source": "attribute",
"selector": "img",
"attribute": "data-link"
},
"alt": {
"type": "string",
"source": "attribute",
"selector": "img",
"attribute": "alt",
"default": ""
},
"id": {
"type": "string",
"source": "attribute",
"selector": "img",
"attribute": "data-id"
Expand Down
2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_ar.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_bg.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_bo.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_ca.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_cs.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_cy.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_da.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_de.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_el.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_enau.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_enca.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_engb.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_ennz.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_enza.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_es.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_esar.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_escl.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_escr.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_fa.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_fr.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_gl.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_he.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_hr.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_hu.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_id.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_is.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_it.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_ja.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_ka.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_ko.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_nb.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_nl.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_nlbe.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_pl.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_pt.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_ptbr.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_ro.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_ru.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_sk.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_sq.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_sr.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_sv.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_th.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_tr.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_uk.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_ur.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_vi.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_zhcn.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/android/raw/i18ncache_data_zhtw.json

Large diffs are not rendered by default.

5 changes: 2 additions & 3 deletions bundle/android/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@
<string name="gutenberg_native_an_unknown_error_occurred_please_try_again" tools:ignore="UnusedResources">An unknown error occurred. Please try again.</string>
<string name="gutenberg_native_annotations_sidebar" tools:ignore="UnusedResources">Annotations Sidebar</string>
<string name="gutenberg_native_border_settings" tools:ignore="UnusedResources">Border Settings</string>
<string name="gutenberg_native_button_url" tools:ignore="UnusedResources">Button URL</string>
<string name="gutenberg_native_button_color_settings_are_coming_soon" tools:ignore="UnusedResources">Button color settings are coming soon.</string>
<string name="gutenberg_native_button_link_url" tools:ignore="UnusedResources">Button Link URL</string>
<string name="gutenberg_native_choose_from_device" tools:ignore="UnusedResources">Choose from device</string>
<string name="gutenberg_native_clear_all_settings" tools:ignore="UnusedResources">Clear All Settings</string>
<string name="gutenberg_native_color_settings" tools:ignore="UnusedResources">Color Settings</string>
<string name="gutenberg_native_content" tools:ignore="UnusedResources">Content…</string>
<string name="gutenberg_native_current_value_is_s" tools:ignore="UnusedResources">Current value is %s</string>
<string name="gutenberg_native_double_tap_and_hold_to_edit" tools:ignore="UnusedResources">Double tap and hold to edit</string>
Expand Down Expand Up @@ -69,7 +69,6 @@
<string name="gutenberg_native_my_pre_publish_panel" tools:ignore="UnusedResources">My pre publish panel</string>
<string name="gutenberg_native_navigate_up" tools:ignore="UnusedResources">Navigate Up</string>
<string name="gutenberg_native_no_application_can_handle_this_request_please_install_a_web_brows" tools:ignore="UnusedResources">No application can handle this request. Please install a Web browser.</string>
<string name="gutenberg_native_note_theme_colors_are_not_available_at_this_time" tools:ignore="UnusedResources">Note: Theme colors are not available at this time.</string>
<string name="gutenberg_native_open_settings" tools:ignore="UnusedResources">Open Settings</string>
<!-- translators: accessibility text. %s: Page break text. -->
<string name="gutenberg_native_page_break_block_s" tools:ignore="UnusedResources">Page break block. %s</string>
Expand Down
2,049 changes: 1,039 additions & 1,010 deletions bundle/ios/App.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/App.js.map

Large diffs are not rendered by default.

5 changes: 2 additions & 3 deletions bundle/ios/GutenbergNativeTranslations.swift
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ private func dummy() {
_ = NSLocalizedString("An unknown error occurred. Please try again.", comment: "")
_ = NSLocalizedString("Annotations Sidebar", comment: "")
_ = NSLocalizedString("Border Settings", comment: "")
_ = NSLocalizedString("Button URL", comment: "")
_ = NSLocalizedString("Button color settings are coming soon.", comment: "")
_ = NSLocalizedString("Button Link URL", comment: "")
_ = NSLocalizedString("Choose from device", comment: "")
_ = NSLocalizedString("Clear All Settings", comment: "")
_ = NSLocalizedString("Color Settings", comment: "")
_ = NSLocalizedString("Content…", comment: "")
_ = NSLocalizedString("Current value is %s", comment: "")
_ = NSLocalizedString("Double tap and hold to edit", comment: "")
Expand Down Expand Up @@ -66,7 +66,6 @@ private func dummy() {
_ = NSLocalizedString("My pre publish panel", comment: "")
_ = NSLocalizedString("Navigate Up", comment: "")
_ = NSLocalizedString("No application can handle this request. Please install a Web browser.", comment: "")
_ = NSLocalizedString("Note: Theme colors are not available at this time.", comment: "")
_ = NSLocalizedString("Open Settings", comment: "")
_ = NSLocalizedString("Page break block. %s", comment: "translators: accessibility text. %s: Page break text.")
_ = NSLocalizedString("Paste URL", comment: "")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,27 +9,32 @@
"selector": ".blocks-gallery-item",
"query": {
"url": {
"type": "string",
"source": "attribute",
"selector": "img",
"attribute": "src"
},
"fullUrl": {
"type": "string",
"source": "attribute",
"selector": "img",
"attribute": "data-full-url"
},
"link": {
"type": "string",
"source": "attribute",
"selector": "img",
"attribute": "data-link"
},
"alt": {
"type": "string",
"source": "attribute",
"selector": "img",
"attribute": "alt",
"default": ""
},
"id": {
"type": "string",
"source": "attribute",
"selector": "img",
"attribute": "data-id"
Expand Down
2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/ar.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/bg.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/bo.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/ca.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/cs.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/cy.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/da.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/de.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/el.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/en-au.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/en-ca.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/en-gb.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/en-nz.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/en-za.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/es-ar.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/es-cl.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/es-cr.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/es.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/fa.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/fr.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/gl.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/he.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/hr.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/hu.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/id.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/is.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/it.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/ja.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/ka.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/ko.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/nb.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/nl-be.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/nl.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/pl.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/pt-br.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/pt.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/ro.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/ru.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/sk.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/sq.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/sr.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/sv.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/th.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/tr.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/uk.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/ur.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/vi.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/zh-cn.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion bundle/ios/assets/i18n-cache/data/zh-tw.json

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,8 @@ PODS:
- React
- RNTAztecView (1.22.0):
- React-Core
- WordPress-Aztec-iOS (= 1.15.0)
- WordPress-Aztec-iOS (1.15.0)
- WordPress-Aztec-iOS (= 1.16.0)
- WordPress-Aztec-iOS (1.16.0)
- Yoga (1.14.0)

DEPENDENCIES:
Expand Down Expand Up @@ -393,8 +393,8 @@ SPEC CHECKSUMS:
ReactCommon: 198c7c8d3591f975e5431bec1b0b3b581aa1c5dd
ReactNativeDarkMode: f61376360c5d983907e5c316e8e1c853a8c2f348
RNSVG: 68a534a5db06dcbdaebfd5079349191598caef7b
RNTAztecView: 8f1559db67161d20d394291a8adca2e473ac365e
WordPress-Aztec-iOS: 004a458e7c4a7b0e6ed1f40695f4ce3b35ba040f
RNTAztecView: 19eb77f908e7d834e35b8f9b323b9069ace39e86
WordPress-Aztec-iOS: 64a2989d25befb5ce086fac440315f696026ffd5
Yoga: f2a7cd4280bfe2cca5a7aed98ba0eb3d1310f18b

PODFILE CHECKSUM: 2ca635b0121a10753500623fbaee9edd0fe6ef92
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "gutenberg-mobile",
"version": "1.22.0",
"version": "1.23.0",
"private": true,
"config": {
"jsfiles": "./*.js src/*.js src/**/*.js src/**/**/*.js",
Expand Down
63 changes: 0 additions & 63 deletions react-native-aztec/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,66 +7,3 @@ Wrapping Aztec Android and Aztec iOS in a React Native component
# License

GPL v2

## Android: Run the example app

Make sure to have an emulator running or an Android device connected, and then:

```
$ cd example/
$ yarn clean:install
$ yarn android
```

This will build the Android library (via `gradle`) and example app, then launch the main example activity on your connected device and run the Metro bundler at the same time.

## iOS: Run the example app

Before being able to run the Example App, you'll need to install [Carthage](https://github.com/Carthage/Carthage) and the dependencies for this project:
```
cd ios
carthage bootstrap --platform iOS
```

Then go back to the root directory of the project and do:
```
$ cd example/
$ yarn clean:install
$ yarn ios
```

This will compile the example project, launch metro, run the simulator and run the app.

## FAQ / Troubleshooting

Q: The example app doesn't run

A: Make sure you have yarn and babel installed (https://yarnpkg.com/lang/en/docs/install/)


Q: The example app gets compiled but ReactNative cannot connect to Metro bundler (I'm on a real device attached through USB)

A: To debug on the device through USB, remember to revert ports before launching metro:
`adb reverse tcp:8081 tcp:8081`


Q: The example app gets compiled but ReactNative shows an error

A: try running, from the root folder in the project
```
$ cd example/
$ yarn start --reset-cache
```

Open a new shell window and run either of these depending on the platform:

```
$ yarn android
```

or

```
$ yarn ios
```

Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
import androidx.annotation.Nullable;
import androidx.core.graphics.ColorUtils;

import android.os.Handler;
import android.os.Looper;
import android.text.Editable;
import android.text.Layout;
import android.text.TextUtils;
Expand Down Expand Up @@ -488,7 +490,13 @@ public Map<String, Integer> getCommandsMap() {
public void receiveCommand(final ReactAztecText parent, int commandType, @Nullable ReadableArray args) {
Assertions.assertNotNull(parent);
if (commandType == mFocusTextInputCommandCode) {
parent.requestFocusFromJS();
// schedule a request to focus in the next layout, to fix https://github.com/wordpress-mobile/gutenberg-mobile/issues/1870
new Handler(Looper.getMainLooper()).post(new Runnable() {
@Override
public void run() {
parent.requestFocusFromJS();
}
});
return;
} else if (commandType == mBlurTextInputCommandCode) {
parent.clearFocusFromJS();
Expand Down
3 changes: 0 additions & 3 deletions react-native-aztec/example/.babelrc

This file was deleted.

83 changes: 0 additions & 83 deletions react-native-aztec/example/App.js

This file was deleted.

Loading

0 comments on commit 70a0649

Please sign in to comment.