Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Add view with accessibility label on top of floating toolbar #20267

Merged
merged 1 commit into from
Feb 18, 2020
Merged

[FIX] Add view with accessibility label on top of floating toolbar #20267

merged 1 commit into from
Feb 18, 2020

Conversation

dratwas
Copy link
Contributor

@dratwas dratwas commented Feb 17, 2020 •
edited
Loading

Description

Gutenberg-mobile PR - wordpress-mobile/gutenberg-mobile#1922
After some changes tests on WP-iOS started failing because of the Paragraph Block 1. Empty can not be found. Seems like it is an issue with the accessibility label. In this PR i added a view with accessibility label and changed the markup a bit. I tested it with VoiceOver and everything works.

How has this been tested?

  • Green CI tests
  • Turn on VoiceOver
  • Add a paragraph block
  • Blur the paragraph after adding
  • The accessibility of Paragraph block should be Paragraph Block. Row 1. Empty

Types of changes

Add View with the accessibility label

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@dratwas dratwas mentioned this pull request Feb 17, 2020
Merged
2 tasks
@etoledom etoledom self-requested a review February 17, 2020 15:31
@etoledom etoledom added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Feb 17, 2020
etoledom
etoledom approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested screen reader on different blocks and WPiOS UI Tests are now passing ✅
Thank you @dratwas 🙏

@dratwas dratwas merged commit 015555f into master Feb 18, 2020
@dratwas dratwas deleted the rnmobile/fix-wp-ios-ui-tests branch February 18, 2020 12:07
@github-actions github-actions bot added this to the Gutenberg 7.6 milestone Feb 18, 2020
mchowning pushed a commit that referenced this pull request Feb 18, 2020
@dratwas @mchowning
Add view with accesibility label on top of floating toolbar (#20267)
7ed130d
mchowning added a commit that referenced this pull request Feb 22, 2020
@mchowning @dratwas @SergioEstevao
Merge changes from mobile v1.23.0 to master (#20374)
e2393de 
* Add view with accesibility label on top of floating toolbar (#20267)

* [FIX] inserter point in mobile app (#20195)

* fix inserter point in gutenberg-mobile

* Make sure that all strong tags are removed from title. (#20291)

Co-authored-by: Drapich Piotr <drapich.piotr@gmail.com>
Co-authored-by: Sérgio Estêvão <sergioestevao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

Assignees

@dratwas dratwas

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 7.6
Development

Successfully merging this pull request may close these issues.
2 participants
@dratwas @etoledom