-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Dependency Updates] Update daggerVersion to 2.45
#18336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ovitrif
merged 8 commits into
deps/main-batch-androidx-compose-kotlin
from
deps/update-dagger-to-2.45
May 2, 2023
Merged
[Dependency Updates] Update daggerVersion to 2.45
#18336
ovitrif
merged 8 commits into
deps/main-batch-androidx-compose-kotlin
from
deps/update-dagger-to-2.45
May 2, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 28, 2023
Contributor
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18336-1237257 | |
| Commit | 1237257 | |
| Direct Download | wordpress-prototype-build-pr18336-1237257.apk |
Contributor
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18336-1237257 | |
| Commit | 1237257 | |
| Direct Download | jetpack-prototype-build-pr18336-1237257.apk |
This was referenced Apr 28, 2023
52b264e to
bce8e5a
Compare
f665d11 to
fac613b
Compare
Release Notes (Compose Compiler): https://developer.android.com/ jetpack/androidx/releases/compose-compiler#1.4.6 Release Notes (Kotlin): https://github.com/ JetBrains/kotlin/releases/tag/v1.8.20
Warning Message: "Companion object of enum class 'FieldType' is uninitialized here. This warning will become an error in future releases. See https://youtrack.jetbrains.com/issue/KT-49110 for details" FYI: This warning will be raised to error in Kotlin version '1.9.0'. ------------------------------------------------------------------------ Existing Behavior: "When one accesses companion object or its members of an enum from the enum entry initializer, they can get an NPE there because the entries of an enum are initialized before the companion object of that enum at runtime. Some of such code was prohibited in Kotlin 1.1 (see KT-11769), but there are still ways to access companion from enum initializer. Note that sometimes the code does not throw an exception, just like this case, however it still observes an uninitialized state of a companion property, and thus needs fixing to avoid any future misbehavior." Proposed Changes: "It's proposed to prohibit all kinds of access to the companion object of an enum from an enum entry initializer." Impact: "Code like this won't compile. This is a rare case, because in most cases such code throws NPE or acts differently than users expect, so it should be fixed right away." ------------------------------------------------------------------------ This commit resolves this warning by creating a regular object inside the enum itself. Initialization of nested objects is not bound to initialization of the enum itself (in opposite to companion objects), so it's safe to access them during initialization of enum entries. Dmitriy Novozhilov (JetBrains): https://youtrack.jetbrains.com/issue/ KT-49110/Prohibit-access-to-members-of-companion-of-enum-class-from- initializers-of-entries-of-this-enum#focus=Comments-27-7246774.0-0 PS: Another idea would be to extract these function to a file, but I chose the 'regular object' idea so as to include only the bare minimum changes here.
Warning Message: "Composable functions with a return type should start with a lowercase letter" Explanation: "@composable functions without a return type should use similar naming to classes, starting with an uppercase letter and ending with a noun. @composable functions with a return type should be treated as normal Kotlin functions, starting with a lowercase letter." ------------------------------------------------------------------------ Renaming all composable functions with a return type to lowercase letter fix these warnings.
Warning Message: "Use AppCompatActivity.setSupportActionBar" Explanation: "Use AppCompatActivity.setSupportActionBar" ------------------------------------------------------------------------ Renaming 'setActionBar()' extension function to 'initActionBar()' automatically resolves this Lint warning as the 'setActionBar(...)' naming no longer collides with the legacy 'android.app.Activity' such, method, which was causing Lint to report a false positive Lint warning in the first place.
Warning Message: "This animation should be started with #start()" Explanation: "Many resources, such as TypedArrays, VelocityTrackers, etc., should be recycled (with a recycle() call) after use. This lint check looks for missing recycle() calls." ------------------------------------------------------------------------ These Lint warnings are suppressed, that is, instead of them being resolved, since a resolution would require a proper investigation and testing. As such, it might be best to ignore this as out of scope, for now, and so as to not introduce any breaking changes to this animation related functionalities that are related to 'AnimatorSet'. PS: Also the fact that the warning mentions 'start()' not being called, while it is, but it is calling upon missing 'recycler()' call, is a bit confusing.
Base automatically changed from
deps/update-androidx-recyclerview-to-1.3.0
to
deps/main-batch-androidx-compose-kotlin
May 2, 2023 14:37
…compose-compiler-and-kotlin-to-1.4.6-and-1.8.20 [Dependency Updates] Update `androidxComposeCompilerVersion` and `kotlinVersion` to 1.4.6 and 1.8.20
Contributor
|
Found 1 violations: The PR caused the following dependency changes: +--- androidx.databinding:viewbinding:7.2.1
| \--- androidx.annotation:annotation:1.0.0 -> 1.5.0
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20
-| +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.20
-| \--- org.jetbrains:annotations:13.0
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20
+| +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.20
+| \--- org.jetbrains:annotations:13.0
-+--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.20
-| +--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 (*)
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.7.20
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 (*)
++--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.20
+| +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.8.20
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.20 (*)
+--- project :libs:analytics
| +--- com.automattic:Automattic-Tracks-Android:2.2.0
-| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.31 -> 1.7.20 (*)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.31 -> 1.8.20 (*)
| | \--- io.sentry:sentry-android-okhttp -> 5.4.3
| | +--- com.squareup.okhttp3:okhttp -> 4.10.0
| | | +--- com.squareup.okio:okio:3.0.0 -> 3.2.0
| | | | \--- com.squareup.okio:okio-jvm:3.2.0
-| | | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.20 -> 1.7.20 (*)
+| | | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.20 -> 1.8.20 (*)
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.20 -> 1.7.20
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.20 -> 1.8.20
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.8.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.32 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.32 -> 1.8.20 (*)
| \--- androidx.preference:preference:1.2.0
| +--- androidx.appcompat:appcompat:1.1.0 -> 1.4.2
| | +--- androidx.activity:activity:1.2.4 -> 1.5.1
| | | +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
| | | +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1
| | | | +--- androidx.core:core-ktx:1.2.0 -> 1.8.0
-| | | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
| | | | +--- androidx.savedstate:savedstate:1.2.0
-| | | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.7.20 (*)
+| | | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.8.20 (*)
-| | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
| | | | \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.1 -> 1.6.4
| | | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4
| | | | | \--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.6.4
-| | | | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 -> 1.7.20 (*)
+| | | | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 -> 1.8.20 (*)
-| | | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.21 -> 1.7.20
+| | | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.21 -> 1.8.20
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 -> 1.8.20 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
| | \--- androidx.fragment:fragment:1.3.6 -> 1.5.5
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
| +--- androidx.fragment:fragment-ktx:1.3.6 -> 1.5.5
| | +--- androidx.activity:activity-ktx:1.5.1
| | | +--- androidx.lifecycle:lifecycle-runtime-ktx:2.5.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
| | | +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
| | | +--- androidx.savedstate:savedstate-ktx:1.2.0
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.8.20 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
| | +--- androidx.collection:collection-ktx:1.1.0
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.20 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.20 -> 1.8.20 (*)
| | +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.5.1
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
| +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.0
| | \--- androidx.customview:customview-poolingcontainer:1.0.0
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
| \--- androidx.slidingpanelayout:slidingpanelayout:1.2.0
| \--- androidx.window:window:1.0.0
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.8.20 (*)
+--- project :libs:image-editor
-| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.20 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.20 (*)
| +--- androidx.navigation:navigation-fragment:2.4.2
| | +--- androidx.navigation:navigation-runtime:2.4.2
| | | +--- androidx.navigation:navigation-common:2.4.2
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.8.20 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.8.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.8.20 (*)
-| \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.7.20
-| +--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 (*)
-| \--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.7.20
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.8.20
+| +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.8.20
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.20 (*)
+--- project :libs:editor
| +--- org.wordpress:aztec:{strictly v1.6.3} -> v1.6.3
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
| +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v1.6.3} -> v1.6.3
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
| +--- org.wordpress.aztec:wordpress-comments:{strictly v1.6.3} -> v1.6.3
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
-| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.20 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.20 (*)
| +--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.94.0
| | +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-2
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.8.20 (*)
| | +--- org.wordpress-mobile.react-native-libraries.v1:react-native-webview:11.6.2
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.8.20 (*)
| | +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.94.0
| | | +--- org.wordpress.aztec:glide-loader:v1.6.3
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.8.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.8.20 (*)
-| \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.8.20 (*)
+--- org.wordpress:fluxc:{strictly 2.26.0} -> 2.26.0
-| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
-| +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.10 -> 1.7.20 (*)
+| +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.10 -> 1.8.20 (*)
| +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.8.20 (*)
| +--- androidx.room:room-ktx:2.4.2
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.8.20 (*)
-| \--- com.google.dagger:dagger:2.42
+| \--- com.google.dagger:dagger:2.42 -> 2.45
+--- org.wordpress:utils:{strictly 3.6.1} -> 3.6.1
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.6.10 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.6.10 -> 1.8.20 (*)
+--- org.wordpress:login:1.3.0
-| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
-| +--- com.google.dagger:dagger:2.42 (*)
+| +--- com.google.dagger:dagger:2.42 -> 2.45 (*)
-| \--- com.google.dagger:dagger-android-support:2.42
-| +--- com.google.dagger:dagger:2.42 (*)
-| +--- com.google.dagger:dagger-android:2.42
-| | +--- com.google.dagger:dagger:2.42 (*)
-| | +--- com.google.dagger:dagger-lint-aar:2.42
-| | +--- androidx.annotation:annotation:1.2.0 -> 1.5.0 (*)
-| | \--- javax.inject:javax.inject:1
-| +--- com.google.dagger:dagger-lint-aar:2.42
-| +--- androidx.activity:activity:1.3.1 -> 1.5.1 (*)
-| +--- androidx.annotation:annotation:1.2.0 -> 1.5.0 (*)
-| +--- androidx.appcompat:appcompat:1.3.1 -> 1.4.2 (*)
-| +--- androidx.fragment:fragment:1.3.6 -> 1.5.5 (*)
-| +--- androidx.lifecycle:lifecycle-common:2.3.1 -> 2.5.1 (*)
-| +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.5.1 (*)
-| +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 -> 2.5.1 (*)
-| \--- javax.inject:javax.inject:1
+| \--- com.google.dagger:dagger-android-support:2.42 -> 2.45
+| +--- com.google.dagger:dagger:2.45 (*)
+| +--- com.google.dagger:dagger-android:2.45
+| | +--- com.google.dagger:dagger:2.45 (*)
+| | +--- com.google.dagger:dagger-lint-aar:2.45
+| | +--- androidx.annotation:annotation:1.2.0 -> 1.5.0 (*)
+| | \--- javax.inject:javax.inject:1
+| +--- com.google.dagger:dagger-lint-aar:2.45
+| +--- androidx.activity:activity:1.5.1 (*)
+| +--- androidx.annotation:annotation:1.2.0 -> 1.5.0 (*)
+| +--- androidx.appcompat:appcompat:1.3.1 -> 1.4.2 (*)
+| +--- androidx.fragment:fragment:1.5.1 -> 1.5.5 (*)
+| +--- androidx.lifecycle:lifecycle-common:2.5.1 (*)
+| +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 (*)
+| +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1 (*)
+| \--- javax.inject:javax.inject:1
+--- com.automattic:about:1.1.0
-| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.5.31 -> 1.7.20 (*)
+| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.5.31 -> 1.8.20 (*)
-| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.31 -> 1.7.20 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.31 -> 1.8.20 (*)
| +--- androidx.compose.ui:ui:1.0.5 -> 1.3.3
| | +--- androidx.compose.runtime:runtime:1.3.3
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
| | +--- androidx.compose.runtime:runtime-saveable:1.3.3
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
| | +--- androidx.compose.ui:ui-geometry:1.3.3
| | | +--- androidx.compose.ui:ui-util:1.3.3
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
| | +--- androidx.compose.ui:ui-graphics:1.3.3
| | | +--- androidx.compose.ui:ui-unit:1.3.3
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.7.20
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.8.20
| | +--- androidx.compose.ui:ui-text:1.3.3
-| | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.7.20
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.8.20
-| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.7.20
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.8.20
| +--- androidx.compose.ui:ui-tooling:1.0.5 -> 1.3.3
| | +--- androidx.activity:activity-compose:1.3.0 -> 1.3.1
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.21 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.21 -> 1.8.20 (*)
| | +--- androidx.compose.animation:animation:1.3.3
| | | +--- androidx.compose.animation:animation-core:1.3.3
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
| | | +--- androidx.compose.foundation:foundation-layout:1.0.0 -> 1.3.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.7.20
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.8.20
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.7.20
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.8.20
| | +--- androidx.compose.material:material:1.0.0 -> 1.3.1
| | | +--- androidx.compose.foundation:foundation:1.2.0 -> 1.3.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.7.20
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.8.20
| | | +--- androidx.compose.material:material-icons-core:1.3.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
| | | +--- androidx.compose.material:material-ripple:1.3.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.7.20
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.8.20
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.7.20
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10 -> 1.8.20
| | +--- androidx.compose.ui:ui-tooling-data:1.3.3
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
| | +--- androidx.compose.ui:ui-tooling-preview:1.3.3
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
| +--- androidx.navigation:navigation-compose:2.4.0-beta02
| | +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.4.0-rc01 -> 2.5.1
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.8.20 (*)
| \--- com.google.android.material:compose-theme-adapter:1.1.1
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.8.20 (*)
+--- com.automattic:stories:2.1.0
-| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.4.20 -> 1.7.20 (*)
+| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.4.20 -> 1.8.20 (*)
-| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.4.20 -> 1.7.20 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.4.20 -> 1.8.20 (*)
| +--- org.jetbrains.kotlinx:kotlinx-serialization-runtime:1.0-M1-1.4.0-rc
| | \--- org.jetbrains.kotlinx:kotlinx-serialization-runtime-jvm:1.0-M1-1.4.0-rc
-| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.0-rc -> 1.7.20 (*)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.0-rc -> 1.8.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.4.0-rc -> 1.7.20
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.4.0-rc -> 1.8.20
| +--- org.jetbrains.kotlin:kotlin-reflect:1.4.20
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.8.20 (*)
| +--- com.automattic.stories:photoeditor:2.1.0
-| | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.4.20 -> 1.7.20 (*)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.4.20 -> 1.8.20 (*)
| | \--- com.automattic.stories:mp4compose:2.1.0
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.4.20 -> 1.7.20 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.4.20 -> 1.8.20 (*)
| \--- androidx.lifecycle:lifecycle-livedata-ktx:2.2.0 -> 2.5.1
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.20 (*)
+--- com.google.android.flexbox:flexbox:3.0.0
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.8.20 (*)
+--- androidx.work:work-runtime-ktx:2.7.1
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.8.20 (*)
+--- com.zendesk:support:5.1.1
| +--- com.zendesk:support-providers:5.1.1
| | +--- com.zendesk:core:4.0.9
| | | +--- com.zendesk:java-common:2.0.0
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.8.20 (*)
-| | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
-| | | +--- com.google.dagger:dagger:2.42 (*)
+| | | +--- com.google.dagger:dagger:2.42 -> 2.45 (*)
| | | \--- com.squareup.okhttp3:logging-interceptor:4.9.2
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.8.20 (*)
| | +--- com.zendesk:guide-providers:1.0.9
-| | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
-| | | \--- com.google.dagger:dagger:2.42 (*)
+| | | \--- com.google.dagger:dagger:2.42 -> 2.45 (*)
-| | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
-| | \--- com.google.dagger:dagger:2.42 (*)
+| | \--- com.google.dagger:dagger:2.42 -> 2.45 (*)
| +--- com.zendesk:guide:1.0.9
| | +--- com.zendesk:sdk-configurations:2.0.3
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
| | +--- com.zendesk:messaging-api:5.2.5
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
| | +--- com.zendesk:messaging:5.2.5
-| | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
| | | +--- com.zendesk:common-ui:4.0.5
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
-| | | \--- com.google.dagger:dagger:2.42 (*)
+| | | \--- com.google.dagger:dagger:2.42 -> 2.45 (*)
-| | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
-| | \--- com.google.dagger:dagger-android:2.42 (*)
+| | \--- com.google.dagger:dagger-android:2.42 -> 2.45 (*)
-| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
-| \--- com.google.dagger:dagger-android:2.42 (*)
+| \--- com.google.dagger:dagger-android:2.42 -> 2.45 (*)
-+--- com.google.dagger:dagger-android-support:2.42 (*)
++--- com.google.dagger:dagger-android-support:2.45 (*)
-+--- com.google.dagger:hilt-android:2.42
-| +--- com.google.dagger:dagger:2.42 (*)
-| +--- com.google.dagger:dagger-lint-aar:2.42
-| +--- com.google.dagger:hilt-core:2.42
-| | +--- com.google.dagger:dagger:2.42 (*)
-| | +--- com.google.code.findbugs:jsr305:3.0.2
-| | \--- javax.inject:javax.inject:1
-| +--- com.google.code.findbugs:jsr305:3.0.2
-| +--- androidx.activity:activity:1.3.1 -> 1.5.1 (*)
-| +--- androidx.annotation:annotation:1.2.0 -> 1.5.0 (*)
-| +--- androidx.fragment:fragment:1.3.6 -> 1.5.5 (*)
-| +--- androidx.lifecycle:lifecycle-common:2.3.1 -> 2.5.1 (*)
-| +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.5.1 (*)
-| +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 -> 2.5.1 (*)
-| +--- androidx.savedstate:savedstate:1.1.0 -> 1.2.0 (*)
-| +--- javax.inject:javax.inject:1
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
++--- com.google.dagger:hilt-android:2.45
+| +--- com.google.dagger:dagger:2.45 (*)
+| +--- com.google.dagger:dagger-lint-aar:2.45
+| +--- com.google.dagger:hilt-core:2.45
+| | +--- com.google.dagger:dagger:2.45 (*)
+| | +--- com.google.code.findbugs:jsr305:3.0.2
+| | \--- javax.inject:javax.inject:1
+| +--- com.google.code.findbugs:jsr305:3.0.2
+| +--- androidx.activity:activity:1.5.1 (*)
+| +--- androidx.annotation:annotation:1.2.0 -> 1.5.0 (*)
+| +--- androidx.fragment:fragment:1.5.1 -> 1.5.5 (*)
+| +--- androidx.lifecycle:lifecycle-common:2.5.1 (*)
+| +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1 (*)
+| +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1 (*)
+| +--- androidx.savedstate:savedstate:1.2.0 (*)
+| +--- javax.inject:javax.inject:1
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.0 -> 1.8.20 (*)
+--- androidx.compose.runtime:runtime-livedata -> 1.3.3
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.10 -> 1.8.20 (*)
+--- androidx.constraintlayout:constraintlayout-compose:1.0.1
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.10 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.10 -> 1.8.20 (*)
+--- io.coil-kt:coil-compose:2.2.2
| \--- io.coil-kt:coil-compose-base:2.2.2
| \--- io.coil-kt:coil-base:2.2.2
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.10 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.10 -> 1.8.20 (*)
+--- com.airbnb.android:lottie-compose:5.2.0
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.8.20 (*)
-\--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.7.20 (*)
+\--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.8.20 (*)
Please review and act accordingly
|
…te-dagger-to-2.45
ovitrif
approved these changes
May 2, 2023
Contributor
ovitrif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesomely flawless 🥇 , thank you @ParaskP7 🚀 ![]()
Contributor
|
Only instrumented tests left to finish from CI checks, I'll merge this already 🚀 |
Contributor
Author
|
Awesome @ovitrif , thanks so much for reviewing, testing and merging this, you rock! 🪨 ❤️ 🚀 |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Parent #17563
Batch Branch: deps/main-batch-androidx-compose-kotlin
This PR updates
daggerVersionto 2.45.FYI: See this related comment for the reasoning behind this update.
PS: @ovitrif I added you as the main reviewer, but not so randomly (context), since I just wanted someone from the WordPress team to be aware of and sign-off on that change for WPAndroid. I also added the @wordpress-mobile/apps-infrastructure team, but this in done only for monitoring purposes, as such, I am not expecting any active review from that team. Thus, feel free to merge this PR if you deem so.
To test:
Hiltrelated potentially breaking changes withandroidx.navigationand the necessity for the 2.5.0 update to interoperate:Image Editing Screen [EditImageActivity.kt + PreviewImageFragment.kt + CropFragment.kt]
ℹ️ This test applies to both, the
JetpackandWordPressapps.ℹ️ Testing this flow and see it working, which is the only flow that is using
androidx.navigation, make me think that updating the Navigation Component library is not necessary at this point of time.blogpost.imageblock.imageblock.media optionsof this image (top right) and then clickedit.Edit Imagescreen is shown and functioning as expected.donemenu option (top right).Merge instructions
trunk.[PR] Not Ready For Merge]label.Regression Notes
Potential unintended areas of impact
Image Editingscreen, which is related toandroidx.navigation, and it not being (yet) update to 2.5.0 and above.What I did to test those areas of impact (or what existing automated tests I relied on)
To testsection above.What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: