Dependency Updates - Main Batch - AndroidX Compose/Kotlin

[ParaskP7]

Parent #17551
Batch Branch: deps/main-batch-androidx-compose-kotlin

---

🚫 Blocked By:

• Update "compileSdk" to 33 #17790 (for more info see below): Cc @irfano
  • Updating AndroidX Compose to 1.2.X requires compileSdkVersion 32 or above.
  • Updating AndroidX Compose to 1.3.X requires compileSdkVersion 33 or above.
  • Updating AndroidX Compose to 1.4.X requires compileSdkVersion 33 or above.
  • Updating AndroidX Compose to any of the currently 4 available BOM related version requires compileSdkVersion 33 or above.

---

Also, note the fact that updating AndroidX Compose Compiler will require a Kotlin update too:

• Updating AndroidX Compose Compiler to 1.2.X requires Kotlin 1.7.0.
• Updating AndroidX Compose Compiler to 1.3.X requires Kotlin 1.7.20.
• Updating AndroidX Compose Compiler to 1.4.X requires Kotlin 1.8.0.

FYI: As such, both the AndroidX Compose Compiler and Kotlin update will be done in one go.

---

In addition to the above, with this AndroidX Compose update we will be switching to using BOM (Bill of Materials) to manage all of our AndroidX Compose library versions. This will help us:

• Avoid potential incompatibility issues as the BOM itself has links to the stable versions of the different AndroidX Compose libraries, in such a way that they work well together.
• Stop explicitly adding any version to the AndroidX Compose library dependencies themselves as when the BOM get configured or updated all the AndroidX Compose libraries will automatically be updated to their corresponding fully compatible versions.

FYI: As such, most probably, this AndroidX Compose update will be targeting the below change:

• gradle.ext.kotlinVersion = '1.7.20' // Requires androidxComposeCompilerVersion 1.3.2
• androidxComposeBomVersion = "2023.01.00" // Requires compileSdkVersion 33
• androidxComposeCompilerVersion = '1.3.2' // Requires kotlinVersion 1.7.20

You will also notice that the AndroidX Compose Compiler is not included in the BOM. This is done due to that fact that the AndroidX Compose Compiler needs to be updated alongside a compatible version of Kotlin and thus it is release in a separate cadence from the rest of AndroidX Compose.

PS: WCAndroid already did a similar update via this Upgrade Kotlin version to 1.7.20 #8091 PR of theirs.

---

Finally, the above AndroidX Compose targeting changes are not targeting neither the latest AndroidX Compose Compiler version, the 1.4.0 version (Jan 17, 2023), nor the latest kotlin version, the 1.8.0 version (Dec 28, 2022). This is done on purpose because:

• We will be already jumping from 1.1.1 into 1.3.2, which is 2 "major" versions of AndroidX Compose Compiler. No need to jump even further, that is into 1.4.0 and 3 "major" versions of AndroidX Compose Compiler.
• We should avoid jumping from Kotlin 1.6.10 into 1.8.0, which is 2 "major" versions away. Also, there is no need in using such a recent version of Kotlin and "probably" better to wait for another minor version of Kotlin first, or just, wait a couple of month to verify 1.8.0 version's stability.

---

This issue is about updating all Main - AndroidX Compose related dependencies for the whole project.

This AndroidX Compose batch contains the following 3 + 1 dependencies:

• kotlinVersion = '1.6.10' (see releases) -> [Dependency Updates] Update androidxComposeCompilerVersion and kotlinVersion to 1.3.2 and 1.7.20 #18303 -> [Dependency Updates] Update androidxComposeCompilerVersion and kotlinVersion to 1.4.6 and 1.8.20 #18338 -> [Dependency Updates] AndroidX Compose/Kotlin (Final Tweaks) #18379 -> commit
• androidxComposeCompilerVersion = 1.1.1 (see releases) -> [Dependency Updates] Update androidxComposeCompilerVersion and kotlinVersion to 1.3.2 and 1.7.20 #18303 -> [Dependency Updates] Update androidxComposeCompilerVersion and kotlinVersion to 1.4.6 and 1.8.20 #18338 -> [Dependency Updates] AndroidX Compose/Kotlin (Final Tweaks) #18379 -> commit
• androidxComposeVersion = '1.1.1' (see releases + comment) -> [Dependency Updates] Add and Update androidxComposeBomVersion to 2023.01.00 #18319 > [Dependency Updates] Update androidxComposeBomVersion to 2023.05.00 #18378
• androidxComposeLifecycleVersion = '2.4.1' (see releases) -> Comment
• coilComposeVersion = '1.4.0' (see releases) -> [Dependency Updates] Update coilComposeVersion to 2.2.2 #18326 -> [Dependency Updates] AndroidX Compose/Kotlin (Final Tweaks) #18379 -> commit

PLUS:

• androidxRecyclerviewVersion = '1.2.1' -> (see releases) -> Related Comment -> [Dependency Updates] Update androidxRecyclerviewVersion to 1.3.0 #18330
• daggerVersion = '2.42' -> (see releases) -> Related Comment -> [Dependency Updates] Update daggerVersion to 2.45 #18336 -> [Dependency Updates] AndroidX Compose/Kotlin (Final Tweaks) #18379 -> commit
• All AndroidX Core libraries -> Related Comment -> [Dependency Updates] Main Batch - AndroidX Core (V2) #18366

[peril-wordpress-mobile]

	Fails
🚫	Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

[ParaskP7]

❗ The androidxComposeLifecycleVersion is currently unused. You will find that androidx.lifecycle:lifecycle-viewmodel-compose utilizes the androidxLifecycleVersion instead. However, since those two dependencies have separate versions, as per the releases here (see lifecycle-viewmodel-compose), I recommend splitting them as part of this work.

[ParaskP7]

❗ The androidxComposeVersion should be split into two versions as compose libraries are now using independent versioning (see here). As such, for now, I recommend splitting that into the androidxComposeCompilerVersion for the compiler version and the androidxComposeVersion for everything else.

[ParaskP7]

FYI: As part of this #17620 PR, both the above comments, here and here, got resolved (see here and here respectively).

[ParaskP7]

✅ The androidxComposeLifecycleVersion update to 2.5.1 is already done as part of the AndroidX Core batch update. As such, this item is now marked as complete.

PS: The androidxComposeLifecycleVersion version will be merged to the androidxLifecycleVersion version as both are pointing to the same version and it doesn't seem that this will change any time soon (see releases and its Declaring dependencies section).

[ParaskP7]

👋 @ovitrif !

Since you are closely involved with AndroidX Compose in WPAndroid, I just updated this issue description with more info about this update. Could you please take a look and give me a 👍 that everything you read there makes sense. If not, pretty please, correct me and suggest an alternative way of moving forward with this AndroidX Compose update, that is of course, when that gets unblocked by the compileSdkVersion 33 upgrade work that @irfano will be doing next week.

🙇 🙏

[ParaskP7]

Also, there is no need in using such a recent version of Kotlin and "probably" better to wait for another minor version of Kotlin first, or just, wait a couple of month to verify 1.8.0 version's stability.

Look at that, just an hour ago we got the newest "minor" version of Kotlin, the 1.8.1 version, I should have talked about that million of euros that I am unexpectedly expecting for everyone, oh come on! 😝

[ovitrif]

👋 @ovitrif !

Since you are closely involved with AndroidX Compose in WPAndroid, I just updated this issue description with more info about this update. Could you please take a look and give me a 👍 that everything you read there makes sense. If not, pretty please, correct me and suggest an alternative way of moving forward with this AndroidX Compose update, that is of course, when that gets unblocked by the compileSdkVersion 33 upgrade work that @irfano will be doing next week.

🙇 🙏

👋 @ParaskP7 Thank you for the ping 🙇! I've checked the description and confirm everything you written makes sense to me 💯 👍

I fully support the plan to rely on Compose Bill of Materials (BOM) for handling the compose library versions once the compileSdkVersion 33 upgrade enables us to move forward, and I agree as well we're better on the safe side and not jump 3 major versions at once 😅

[ParaskP7]

I've checked the description and confirm everything you written makes sense to me 💯 👍

Coolio! 🥇

I fully support the plan to rely on Compose Bill of Materials (BOM) for handling the compose library versions once the compileSdkVersion 33 upgrade enables us to move forward...

Thank you so much for the confirmation on this change @ovitrif , much appreciated! 🙇

...and I agree as well we're better on the safe side and not jump 3 major versions at once 😅

😅 ⚔️ 😅