[Dependency Updates] Update androidxComposeCompilerVersion and kotlinVersion to 1.3.2 and 1.7.20
#18303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release Notes (Compose Compiler): https://developer.android.com/ jetpack/androidx/releases/compose-compiler#1.3.2 Release Notes (Kotlin): https://github.com/ JetBrains/kotlin/releases/tag/v1.7.20
Warning Message: "This label is now resolved to 'class ReaderPostDetailFragment' but soon it will be resolved to the closest 'function showPostInWebView extension receiver'. Please consider introducing or changing explicit label name"
Warning Message: "Actual value of parameter 'refreshing' is always 'false'" ------------------------------------------------------------------------ Currently 'setRefreshing(false)' is used twice and 'setRefreshing(true)' is never used, but this doesn't mean it will not be used in the future, or wasn't used in the past. As such, keeping this method signature and suppressing this warning for the time being seems to be the better approach here.
Explanation: "This deprecation overrides deprecated member but not marked as deprecated itself. This deprecation won't be inherited in future releases. Please add @deprecated or suppress. See https://youtrack.jetbrains.com/issue/KT-47902 for details." ------------------------------------------------------------------------ After running the Kotlin migration analysis these warnings appeared on the IDE's dashboard. Those are now suppress instead of having them producing a "light" IDE warning. This is done just so those warnings disappear at the IDE level, and also, so that those become more visible, code-wise, by being visually suppressed.
9 tasks
Contributor
|
Found 1 violations: The PR caused the following dependency changes:-+--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21
-| +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21
-| | +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.21
-| | \--- org.jetbrains:annotations:13.0
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.6.21
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
++--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.20
+| +--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20
+| | +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.7.20
+| | \--- org.jetbrains:annotations:13.0
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.7.20
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 (*)
+--- project :libs:analytics
| +--- com.automattic:Automattic-Tracks-Android:2.2.0
-| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.31 -> 1.6.21 (*)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.31 -> 1.7.20 (*)
| | \--- io.sentry:sentry-android-okhttp -> 5.4.3
| | +--- com.squareup.okhttp3:okhttp -> 4.9.2
| | | +--- com.squareup.okio:okio:2.8.0 -> 2.10.0
-| | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.21 (*)
+| | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.7.20 (*)
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.4.20 -> 1.6.21
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.4.20 -> 1.7.20
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.21 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.7.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.32 -> 1.6.21 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.32 -> 1.7.20 (*)
| \--- androidx.preference:preference:1.2.0
| +--- androidx.appcompat:appcompat:1.1.0 -> 1.4.2
| | +--- androidx.activity:activity:1.2.4 -> 1.5.1
| | | +--- androidx.lifecycle:lifecycle-viewmodel:2.5.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
| | | +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1
| | | | +--- androidx.core:core-ktx:1.2.0 -> 1.8.0
-| | | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+| | | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
| | | | +--- androidx.savedstate:savedstate:1.2.0
-| | | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.6.21 (*)
+| | | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.7.20 (*)
-| | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+| | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
| | | | \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.1 -> 1.6.4
| | | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4
| | | | | \--- org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.6.4
-| | | | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 (*)
+| | | | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 -> 1.7.20 (*)
-| | | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.21
+| | | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.21 -> 1.7.20
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 -> 1.7.20 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
| | \--- androidx.fragment:fragment:1.3.6 -> 1.5.5
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
| +--- androidx.fragment:fragment-ktx:1.3.6 -> 1.5.5
| | +--- androidx.activity:activity-ktx:1.5.1
| | | +--- androidx.lifecycle:lifecycle-runtime-ktx:2.5.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
| | | +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
| | | +--- androidx.savedstate:savedstate-ktx:1.2.0
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.6.21 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.7.20 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
| | +--- androidx.collection:collection-ktx:1.1.0
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.20 -> 1.6.21 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.20 -> 1.7.20 (*)
| | +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.5.1
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
| \--- androidx.slidingpanelayout:slidingpanelayout:1.2.0
| \--- androidx.window:window:1.0.0
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.6.21 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.7.20 (*)
+--- project :libs:image-editor
-| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.20 (*)
| +--- androidx.navigation:navigation-fragment:2.4.2
| | +--- androidx.navigation:navigation-runtime:2.4.2
| | | +--- androidx.navigation:navigation-common:2.4.2
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.6.21 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.7.20 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.6.21 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.7.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.6.21 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.7.20 (*)
-| \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10
-| +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.6.21 (*)
-| \--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.10
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.6.21 (*)
+| \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.7.20
+| +--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.7.20
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 (*)
+--- project :libs:editor
| +--- org.wordpress:aztec:{strictly v1.6.3} -> v1.6.3
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
| +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v1.6.3} -> v1.6.3
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
| +--- org.wordpress.aztec:wordpress-comments:{strictly v1.6.3} -> v1.6.3
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
-| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.20 (*)
| +--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.94.0-alpha1
| | +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-2
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.6.21 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.7.20 (*)
| | +--- org.wordpress-mobile.react-native-libraries.v1:react-native-webview:11.6.2
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.21 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.7.20 (*)
| | +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.94.0-alpha1
| | | +--- org.wordpress.aztec:glide-loader:v1.6.3
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.7.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.7.20 (*)
-| \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 (*)
+| \--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.7.20 (*)
+--- org.wordpress:fluxc:{strictly 2.25.0} -> 2.25.0
-| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
-| +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.10 (*)
+| +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.10 -> 1.7.20 (*)
| +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.6.21 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.7.20 (*)
| \--- androidx.room:room-ktx:2.4.2
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.6.21 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
+--- org.wordpress:utils:{strictly 3.6.0} -> 3.6.0
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.6.10 -> 1.6.21 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.6.10 -> 1.7.20 (*)
+--- org.wordpress:login:1.3.0
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+--- com.automattic:about:1.1.0
-| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.5.31 -> 1.6.10 (*)
+| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.5.31 -> 1.7.20 (*)
-| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.31 -> 1.6.21 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.31 -> 1.7.20 (*)
| +--- androidx.compose.ui:ui:1.0.5 -> 1.1.1
| | +--- androidx.compose.runtime:runtime-saveable:1.1.1
| | | +--- androidx.compose.runtime:runtime:1.1.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.6.21 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.6.21 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
| | +--- androidx.compose.ui:ui-geometry:1.1.1
| | | +--- androidx.compose.ui:ui-util:1.1.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.6.21 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.6.21 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
| | +--- androidx.compose.ui:ui-graphics:1.1.1
| | | +--- androidx.compose.ui:ui-unit:1.1.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.6.21 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.10 -> 1.6.21
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.10 -> 1.7.20
| | +--- androidx.compose.ui:ui-text:1.1.1
-| | | +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.10 -> 1.6.21
+| | | +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.10 -> 1.7.20
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.6.21 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
-| | +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.10 -> 1.6.21
+| | +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.10 -> 1.7.20
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.6.21 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
| +--- androidx.compose.ui:ui-tooling:1.0.5
| | +--- androidx.compose.ui:ui-tooling-preview:1.0.5 -> 1.1.1
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.6.21 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
| | +--- androidx.compose.ui:ui-tooling-data:1.0.5
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.21 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.7.20 (*)
-| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.21 (*)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.7.20 (*)
| | +--- androidx.compose.material:material:1.0.5 -> 1.1.1
| | | +--- androidx.compose.animation:animation-core:1.0.0 -> 1.1.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.6.21 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
| | | +--- androidx.compose.foundation:foundation:1.1.1
| | | | +--- androidx.compose.animation:animation:1.1.1
| | | | | +--- androidx.compose.foundation:foundation-layout:1.0.0 -> 1.1.1
-| | | | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.10 -> 1.6.21
+| | | | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.10 -> 1.7.20
-| | | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.10 -> 1.6.21
+| | | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.10 -> 1.7.20
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.10 -> 1.6.21
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.10 -> 1.7.20
| | | +--- androidx.compose.material:material-icons-core:1.1.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.6.21 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
| | | +--- androidx.compose.material:material-ripple:1.1.1
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.10 -> 1.6.21
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.10 -> 1.7.20
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.10 -> 1.6.21
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.10 -> 1.7.20
| | \--- androidx.activity:activity-compose:1.3.1
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.21 -> 1.6.21 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.21 -> 1.7.20 (*)
| +--- androidx.navigation:navigation-compose:2.4.0-beta02
| | +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.4.0-rc01 -> 2.5.1
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.21 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.7.20 (*)
| +--- com.google.accompanist:accompanist-drawablepainter:0.20.2
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.31 -> 1.6.21 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.31 -> 1.7.20 (*)
| \--- com.google.android.material:compose-theme-adapter:1.1.1
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.6.21 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.7.20 (*)
+--- com.automattic:stories:2.1.0
-| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.4.20 -> 1.6.10 (*)
+| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.4.20 -> 1.7.20 (*)
-| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.4.20 -> 1.6.21 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.4.20 -> 1.7.20 (*)
| +--- org.jetbrains.kotlinx:kotlinx-serialization-runtime:1.0-M1-1.4.0-rc
| | \--- org.jetbrains.kotlinx:kotlinx-serialization-runtime-jvm:1.0-M1-1.4.0-rc
-| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.0-rc -> 1.6.21 (*)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.0-rc -> 1.7.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.4.0-rc -> 1.6.21
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.4.0-rc -> 1.7.20
| +--- org.jetbrains.kotlin:kotlin-reflect:1.4.20
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.21 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.7.20 (*)
| +--- com.automattic.stories:photoeditor:2.1.0
-| | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.4.20 -> 1.6.21 (*)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.4.20 -> 1.7.20 (*)
| | \--- com.automattic.stories:mp4compose:2.1.0
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.4.20 -> 1.6.21 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.4.20 -> 1.7.20 (*)
| \--- androidx.lifecycle:lifecycle-livedata-ktx:2.2.0 -> 2.5.1
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.7.20 (*)
+--- com.google.android.flexbox:flexbox:3.0.0
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.6.21 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.7.20 (*)
+--- androidx.work:work-runtime-ktx:2.7.1
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.21 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.7.20 (*)
+--- androidx.constraintlayout:constraintlayout-compose:1.0.1
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.10 -> 1.6.21 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.10 -> 1.7.20 (*)
+--- com.airbnb.android:lottie-compose:5.2.0
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+--- androidx.compose.runtime:runtime-livedata:1.1.1
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.6.21 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
+--- io.coil-kt:coil-compose:1.4.0
| \--- io.coil-kt:coil:1.4.0
| \--- io.coil-kt:coil-base:1.4.0
-| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.5.30 -> 1.6.10 (*)
+| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.5.30 -> 1.7.20 (*)
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.21 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.7.20 (*)
+--- com.zendesk:support:5.1.1
| +--- com.zendesk:support-providers:5.1.1
| | +--- com.zendesk:core:4.0.9
| | | +--- com.zendesk:java-common:2.0.0
-| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.6.21 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.7.20 (*)
-| | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+| | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
| | | \--- com.squareup.okhttp3:logging-interceptor:4.9.2
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.6.21 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.7.20 (*)
| | +--- com.zendesk:guide-providers:1.0.9
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
| +--- com.zendesk:guide:1.0.9
| | +--- com.zendesk:sdk-configurations:2.0.3
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
| | +--- com.zendesk:messaging-api:5.2.5
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
| | +--- com.zendesk:messaging:5.2.5
-| | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+| | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
| | | \--- com.zendesk:common-ui:4.0.5
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+--- com.google.dagger:hilt-android:2.42
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.6.21 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
-\--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 (*)
+\--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.7.20 (*)
Please review and act accordingly
|
Contributor
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18303-c5b6967 | |
| Commit | c5b6967 | |
| Direct Download | wordpress-prototype-build-pr18303-c5b6967.apk |
Contributor
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18303-c5b6967 | |
| Commit | c5b6967 | |
| Direct Download | jetpack-prototype-build-pr18303-c5b6967.apk |
ovitrif
approved these changes
Apr 24, 2023
Contributor
There was a problem hiding this comment.
LGTM 
Test Results
- Deps tree diff ✅ everything
kotlingoes up to1.7.20
Kotlin Update
- Reader Post Detail Screen ✅
JP+WP
Compose Compiler Update:
- Login screen ✅
JP - QR Code Auth Screen ✅
JP - Jetpack Static Poster Screen ✅
WP - Jetpack Migration Delete Screen ✅
JP - Blaze Screen ✅
JP - Blogging Prompts Screen ✅
JP - Individual Plugin Screen ✅
WPNote
Simply apply this patch to quickly test this screen:individual.patch.
Copy it to the root dir of your local repo clone and run:git apply individual.patch
Then build & run WP, go to the Site Picker and it should show
- Jetpack Full Plugin Install Screen ✅
WPUse this diff patch, the same way as for the above:
full.patch
The screen should then appear onMy Siteas an overlay - JetpackRemoteInstallActivity ✅
WPSee above, just press
Installon that dialog - Site Creation Domain Screen ✅
JP
FWIW I tested this and it works as expected. I'm everyday in that screen, it was simple for me to test it 😅
➕ 🆕 Jetpack Migration Flow Screens ✅ JP
For this, install both apps, clear cache & data of JP app and restart it. The migration flow should appear, which is also built with Compose.
ovitrif
deleted the
deps/update-androidx-compose-compiler-and-kotlin-to-1.3.2-and-1.7.20
branch
Contributor
Author
|
You are the best of the best of the best @ovitrif , thanks so much for the review, testing, merging, but most of all, thank you for enhancing the testing instructions and filling the gaps here, more so by adding the patches to it, you are awesome!!! 🙇 ❤️ 🚀 Question (❓): Do you think it is better if I add you as the reviewer on all the subsequent PRs that I'll be creating on updating FYI: After completing this first update to |
Contributor
Thank you @ParaskP7 ❤️🙏🚀
It's a good idea IMHO 🙏, I agree the need to build the experience for testing all the compose flows makes it relevant to go with this approach to move forward in a faster way ❤️ ps. Plus my own opinion is that we are already behind regarding a few things, thus finding great ways to fasten things up might be just what we need at this time 🚀 |
Contributor
Author
Great, thanks for agreeing with this idea @ovitrif , I'll then proceed as such and will be adding you as the reviewer to those PRs, at least you being the main one (just in case I need to add more engineers into some of those)! 🙇 ❤️ 🚀 PS: Btw, at any point in time, if/when you'll feel that this process is getting too hard on you, feel free to let me know and I'll start rotating those LET'S DO THIS! 🥇 💪 🌟 |
This was referenced Apr 25, 2023
This was referenced May 4, 2023
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent #17563
Batch Branch: deps/main-batch-androidx-compose-kotlin
This PR update
androidxComposeCompilerVersionandkotlinVersionto 1.3.2 and 1.7.20 respectively.Note that the latest 1.4.6 update of
androidxComposeCompilerVersionand 1.8.20 ofkotlinVersionhas been decided to be done at a later point in time in order to avoid jumping 3 major versions, all at once (see comment).PS: @ovitrif I added you as the main reviewer, but not so randomly, since I just wanted someone from the WordPress team to be aware of and sign-off on that change for WPAndroid. I also added the @wordpress-mobile/apps-infrastructure team, but this in done only for monitoring purposes, as such, I am not expecting any active review from that team. Thus, feel free to merge this PR if you deem so.
FYI: For me to come down with the below testing instructions I first analysed the current state of
AndroidX Composein the codebase, identified all moving parts (🤞) and then, based on that graph (see below) I started pin-pointing and testing the relevant screens in order to get as much confident as possible that this update isn't breaking anything obvious.PS.1: The
[X]you would see next to some classes correspond to the number presented on the more explicitCompose Compiler Updaterelated testing instruction below.PS.2 I didn't test each specific
composerelatedcomponentsas those, most probably (🤞), will be tested as part of testing the wholeComposerelated screens that are using those, thus you are seeing an asterisk (*) next to those, where I omit any files within.Current State of Compose: Graph [Per Source Set]
Main:CoreFeatures:BlazeOverlayFragment[5]BlazeWebViewFragment[5]BloggingPromptsListActivity[6]JetpackStaticPosterActivity[3]WPJetpackIndividualPluginFragment[7]JetpackFullPluginInstallActivity[8]JetpackFullPluginInstallOnboardingDialogFragment[8]JetpackRemoteInstallActivity[9]JetpackMigrationFragment[4]JetpackStaticPosterFragment[3]JetpackInstallFullPluginCardViewHolder[8]QRCodeAuthFragment[2]SiteCreationDomainViewHolder[10]WordPress:Core:Features:LoginPrologueRevampedFragment[1]Jetpack:CoreFeatures:LoginPrologueRevampedFragment[1]I wanted to be thorough with the testing instructions here as I want to base all the subsequent such
Composeupdates on this template, which I will then copy-paste on all other such PRs, without redoing this test related documentation step.Thus, it would be helpful if we get this right now, enhance it with whatever I might have missed, like a testing instruction here-and-there, which I don't know how to (quickly) complete, and then take all that as the source of truth (or at least the basis) for all other such
Composeupdate, even future ones. All and every help I'll get from you here are VERY welcome! 🙏 ❤️ 🙇To test:
Kotlinupdate, smoke test both, the WordPress and Jetpack apps, and see if they both work as expected.Compose Compilerupdate, thoroughly smoke test any Compose related screens, on both, the WordPress and Jetpack apps, and see if they both work as expected.Kotlin Update:
Reader Post Detail Screen [ReaderPostDetailFragment.kt]
ℹ️ You would need to find a post that is private atomic and requiring cookie refresh.
❓ Unfortunately, I am not sure how to do that.
Readertab ->DISCOVERsub-tab.Post Detailscreen is shown and functioning as expected.Compose Compiler Update:
1. Login Screen [LoginPrologueRevampedFragment.kt]
ℹ️ This test applies to both, the
WordPressandJetpackapps.Loginscreen is shown and functioning as expected.2. QR Code Auth Screen [QRCodeAuthFragment.kt]
ℹ️ This test applies to the
Jetpackapp.ℹ️ You don't have to follow all 3 steps, just logging in with a non
A8Cand non2FAenabledaccount, followed by tapping the
Scan Login Codeitem on theMescreen should be enough, whichis effectively just
Step.1and the beginning ofStep.3.Step.1:
Jetpackapp (note that you don't need a release build, a debug build willsuffice).
Jetpackapp with aWP.comaccount (note that you need to use a nonA8Caccountand a non
2FAenabled account).Mescreen (click on avatar at top-right).(STOP)
Step.2:
wordpress.com(note that if you are logged-in, log-out first).Log Inlink (top-right).Login via the mobile applink in the list of options below the main Continue button(bottom-middle).
Login via the mobile appview andUse QR Code to loginis shown, along witha QR code for you to scan.
Step.3:
Scan Login Codeitem on theMescreen you are currently at.verify that you have successfully logged-in and are able to use WordPress as expected.
3a. Jetpack Static Poster Screen [JetpackStaticPosterActivity.kt + JetpackStaticPosterFragment.kt]
ℹ️ This test applies to the
WordPressapp.My Sitetab ->MENUsub-tab.Trafficsection in the middle and click on itsStatsoption.Jetpack Static Posterscreen is shown and functioning as expected, that is,instead of showing the
Statsscreen (like it is done with theJetpackapp).3b. Jetpack Static Poster Screen [JetpackStaticPosterFragment.kt]
ℹ️ This test applies to the
WordPressapp.ReaderorNotificationstab.Jetpack Static Posterscreen is shown and functioning as expected, that is,instead of showing the
ReaderorNotificationsscreen (like it is done with theJetpackapp).4. Jetpack Migration Screen [JetpackMigrationFragment.kt]
ℹ️ This test applies to the
Jetpackapp.My Sitetab ->HOMEsub-tab.Jetpack Migrationscreen is shown and functioning as expected.5. Blaze Screen [BlazeOverlayFragment.kt + BlazeWebViewFragment.kt]
ℹ️ This test applies to the
Jetpackapp.My Sitetab ->MENUsub-tab.Trafficsection in the middle and click on itsBlazeoption.Blazescreen is shown and functioning as expected.6. Blogging Prompts Screen [BloggingPromptsListActivity.kt]
ℹ️ This test applies to the
Jetpackapp.My Sitetab ->HOMEsub-tab.Promptscard on top and click on its options (top right).View more prompts.Blogging Promptsscreen is shown and functioning as expected.7. Individual Plugin Screen [WPJetpackIndividualPluginFragment.kt]
❓️ Not sure how to best and quickly test this, let me know if you have an idea.
8. Jetpack Full Plugin Install Screen [JetpackFullPluginInstallOnboardingDialogFragment.kt + JetpackFullPluginInstallActivity.kt + JetpackInstallFullPluginCardViewHolder.kt]
❓️ Not sure how to best and quickly test this, let me know if you have an idea.
9. Jetpack Remove Install Screen [JetpackRemoteInstallActivity.kt]
❓️ Not sure how to best and quickly test this, let me know if you have an idea.
10. Site Creation Domain Screen [SiteCreationDomainViewHolder.kt]
❗️ Not sure if it is worth testing this, but I am leaving it here just in case as I am seeing this
this Compose related
DisposeOnViewTreeLifecycleDestroyedimport that related to thisRemove this for Compose 1.2.0-beta02+ and RecyclerView 1.3.0-alpha02+TODO comment.❓ Maybe it is worth testing this with the
RecyclerView 1.3.1update later on and by the end ofupdating Compose/Kotlin and all its related libraries (see description).
#17563
Regression Notes
Potential unintended areas of impact
Loginscreen, theJetpack Migrationscreens or theBlazegreen (to name a few).What I did to test those areas of impact (or what existing automated tests I relied on)
To testsection above.What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: