Updates: target sdk to 31 #17153
Updates: target sdk to 31 #17153
Conversation
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | WordPress | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | 6814ccf | |
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | Jetpack | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | 6814ccf | |
There was a problem hiding this comment.
👋 @AjeshRPai and thank you so much for opening this PR, we are so close with Android 12! 🎉 ❤️ 🌟
I have reviewed and quickly smoked tested both apps, WordPress and Jetpack, everything seems to be working as expected, great job! 🥇
Testing Instructions & Regression Notes
However, before approving and merging this PR to trunk, I would recommend adding someone from the quality engineering team to do a thorough smoke testing of the entire app, both apps actually, WordPress and Jetpack, sign-in/up included, just to make sure they give us an extra 👍 that all features are working as expected. Then, we can do another one of those during the beta testing phase. Wdyt?
This comment was marked as outdated.
This comment was marked as outdated.
Awesome, thank you for that @AjeshRPai ! PS: In case you would need any additional help from my side, please reach out to me again. I'll be monitoring the progress on this PR anyway, but just in case, please do ping me if you need an extra pair of eyes. 💯 |
|
@AjeshRPai thanks for thinking about beta testing! |
I have added a note to the RELEASE-NOTES.txt with this commit d94daa4 👍🏼
Will do 👍🏼 , thanks for that suggestion 👍🏼 |
|
This PR is ready for review. 👍🏼 . All the libraries are updated to make sure it is compatible with Android 12. |
|
👋 @AjeshRPai !
I did take a quick look to verify that all libs are pointing to the correct PR hash, and then I did took a quick look at all the draft PRs that are associated with the PR hashes. Great work both @AjeshRPai and @fluiddot ! 🌟 🌟 🌟 Now, we need to make sure this PR is thoroughly tested so that we could merge it by the end of this week, beginning of next. This will give us, the engineers, some additional time to fix any problems that might arise due to this change. Then, via the |
|
Heads up that I updated the Gutenberg Mobile reference (e361082) to fix an issue I identified related to Aztec (more info here). |
ravishanker
left a comment
ravishanker
left a comment
There was a problem hiding this comment.
Great work @AjeshRPai 🚀
Tested on the following and seems to work fine
- WP and JP apps
- Login, including Google auto-fill
- Signup
- Reset password
- Jetpack install
- media upload
- permissions
- Notificaitons
- Create, Publish Blog and Story posts
Merge it after dependent PRs merged.
zwarm
left a comment
zwarm
left a comment
There was a problem hiding this comment.
@AjeshRPai - Looking good!!!
I retested all major features (+ including permission requests)
- Login
- Posts/Story/Pages (with and without media)
- Media (video, pictures)
- Notifications
- Reader
- Site creation
- Site dashboard tabs
- Quick start tour
Thanks again for wrangling this and sticking with it through the long haul!!
|
WP in Samsung S20 5G, Android 12:
The only problem I have encountered is Blogging Reminders. I am not getting the notification after setting it. I have checked my site timezone and notification permissions. JP in Samsung S20 5G, Android 12:
Same issue with Blogging Reminders |
Thanks for the ping!
@AjeshRPai I see this PR has a milestone of So just wanted to check, is the date you quoted (which is also the Actual Shipping Date on the Project Thread) the wrong one, or is the PR milestone the one being misleading? 🤔
[EDIT] I now realize that the Nov 1 deadline is the deadline set by Google… so we won't be able to submit to Google new builds that are not Android 12 past this date… So that means the PR's milestone is correct after all, and not only that, it's a hard deadline that we can't afford to miss (i.e. I won't be able to just move this PR to next milestone in case it hasn't yet landed next Monday when I'll do the code freeze for |
This comment was marked as resolved.
This comment was marked as resolved.
@AjeshRPai The alpha version In relation to this comment, we could update and check ✅ the following items:
Looks like all libraries are updated and the PR is ready, so from my side, feel free to continue with the merge 🎊 . |
Yup right. @AliSoftware
Yup right again. I should have explained it in the comment itself to avoid confusion. Sorry about that.
👍🏼 . Updated the comments. |
|
Thanks for the confirmation @AjeshRPai … and for working on this big migration and landing it in time! 🎉 💪 👏 |
9 participants
Parent #16062
Internal Project ref - pbArwn-5om-p2
This PR can be used to test and close #16068 as well.
Changes
Expand
1. Updates Android target SDK to 31
This PR changes the target SDK to 31. It would be good to test the entire app to double-check if there are any issues which would be introduced due to the target platform change. Some of the areas which can be impacted by this change would be
2. Updates play services auth library from
18.1.0to20.3.0While testing on the Android 12 device, I noticed a crash on trying to fill the email address using google autofill manager.
On further investigation, I found that the intent returned by google API for the login hint dialogue doesn't have the mutability declared. This issue was fixed on the dependency version
com.google.android.gms:play-services-auth:20.3.0. Hence updated the dependency to resolve this issue3. Updates Deeplink intent receiver activity exported attribute to true
According to the Android 12 changes - If your app targets Android 12 or higher and contains activities, services, or broadcast receivers that use intent filters, you must explicitly declare the android:exported attribute for these app components. Reference.
4. Updates all the library versions
In order to make all the libraries compatible with Android 12, compileSdkVersion and targetSdkVersion of the dependant libraries are updated to Api Level 31. Although this won't make any issues as this change wouldn't affect the app( WooCommerce,Wordpress Android) since the targetSdkVersion on the app has a higher priority and the manifest merge wouldn't make any issues, its better to update those libraries to make every library consistent with the apps.
Testing instructions
Expand
Test 1
Some of the areas which can be impacted by the change in this PR and libraries PR would be
Check if the features, works as expected
Test 2 -
This scenario needs special attention as there has been a change in the autofill library dependency
login or signup using wpcombuttonTest 3 Code changes in the dependant libraries
Review Instructions
Expand
Once the changes for the following libraries are done for making them compatible with Android 12. Update the library versions in the Gradle file. Then the review can be taken up.
Update target SDK version of the Libraries to 31
Merge Instructions
Expand
The status of the PR of the libraries for making each of them compatible with Android 12
We have updated the library versions on build.gradle
Merge
Regression Notes
Potential unintended areas of impact
Features not working as expected
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.