This repository was archived by the owner on Jul 10, 2025. It is now read-only.
Updates: compile sdk version and target sdk version to 31 for Android 12 Migration #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change wouldn't affect the libary as this is only on the example app. Change was necessary because of the CI failure
|
You can test the changes on this Pull Request by downloading the APK here. |
42 tasks
ParaskP7
approved these changes
Oct 13, 2022
Contributor
There was a problem hiding this comment.
LGTM! 💯
As per the testing that was done as part of WordPress-Android#17153, which verifies correctness of this library working alongside the WPAndroid client app, I am approving this PR too.
PS: I also quickly smoke tested the example loop app.
AjeshRPai
deleted the
issue/723-update-targetsdkversion-and-compilesdkversion-to-31
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #723
This PR updates the target SDK version to 31 for the Android 12 migration
Test Instructions