Skip to content
This repository was archived by the owner on Feb 6, 2025. It is now read-only.

Conversation

@AjeshRPai
Copy link
Contributor

Closes #96

This PR updates the target SDK version to 31 for the Android 12 migration

Test Instructions

  • Install the app from the Parent PR
  • Make sure the functionalities provided by the library work as expected - login

@AjeshRPai AjeshRPai self-assigned this Sep 29, 2022
@AjeshRPai AjeshRPai linked an issue Sep 29, 2022 that may be closed by this pull request
@AjeshRPai AjeshRPai requested a review from ParaskP7 October 13, 2022 08:12
@AjeshRPai AjeshRPai marked this pull request as ready for review October 13, 2022 08:12
Copy link
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

As per the testing that was done as part of WordPress-Android#17153, which verifies correctness of this library working alongside the WPAndroid client app, I am approving this PR too.

@AjeshRPai AjeshRPai merged commit ccb2fbe into trunk Oct 13, 2022
@AjeshRPai AjeshRPai deleted the issue/96-update-targetsdkversion-and-compilesdkversion-to-31 branch October 13, 2022 10:06
@ParaskP7 ParaskP7 self-assigned this Oct 13, 2022
wzieba pushed a commit that referenced this pull request Oct 15, 2024
…kversion-and-compilesdkversion-to-31

Updates compile sdk version and target sdk version to 31 for Android 12 compatibility
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update targetSdkVersion and compileSdkVersion to 31

2 participants