Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netlify adapter doesn't work with base #45

Closed
1 task
florian-lefebvre opened this issue Oct 27, 2023 · 0 comments · Fixed by #51
Closed
1 task

netlify adapter doesn't work with base #45

florian-lefebvre opened this issue Oct 27, 2023 · 0 comments · Fixed by #51

Comments

@florian-lefebvre
Copy link
Member

florian-lefebvre commented Oct 27, 2023 •
edited
Loading

Astro Info

Astro                    v3.4.0
Node                     v18.14.1
System                   Windows (x64)
Package Manager          pnpm
Output                   server
Adapter                  @astrojs/netlify
Integrations             @astrojs/mdx
                         @astrojs/sitemap

Describe the Bug

When setting a base, deployment actually serves files from the root. I don't know if that's caused by setting output to server.

For example, site is available at https://astro-netlify-base-test.netlify.app/ but should only be at https://astro-netlify-base-test.netlify.app/test, which thows a 404

What's the expected result?

Base should be taken into account

Link to Minimal Reproducible Example

https://github.com/florian-lefebvre/astro-netlify-base-test

Participation

  • I am willing to submit a pull request for this issue.
@florian-lefebvre florian-lefebvre mentioned this issue Oct 30, 2023
Merged
@alexanderniebuhr alexanderniebuhr mentioned this issue Nov 1, 2023
Merged
alexanderniebuhr added a commit that referenced this issue Nov 3, 2023
@florian-lefebvre @alexanderniebuhr
test(netlify): add base fixture and prepare test (#45) (#49)
3540bd2 
* test(netlify): add base fixture and prepare test

* Update base.test.js

* fix(netlify): test indentation

---------

Co-authored-by: Alexander Niebuhr <alexander@nbhr.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update deps withastro/adapters
1 participant
@florian-lefebvre