Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(underscore-redirects): add base to input paths #8953

Conversation

alexanderniebuhr
Copy link
Member

@alexanderniebuhr alexanderniebuhr commented Oct 30, 2023

Changes

  • adds base path as prefix for input paths

Testing

  • tested manually calling the function

Docs

  • changeset only

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2023

🦋 Changeset detected

Latest commit: 596df58

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexanderniebuhr
Copy link
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added the pr: docs A PR that includes documentation for review label Oct 30, 2023
@florian-lefebvre
Copy link
Member

Is that related to withastro/adapters#45 ?

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@alexanderniebuhr
Copy link
Member Author

Is that related to withastro/adapters#45 ?

@florian-lefebvre yes it should fix it (hopefully)

.changeset/odd-maps-glow.md Outdated Show resolved Hide resolved
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that we don't have tests concerns me. We really should!

I am OK with merging it, but the team should add some infra to test these utilities.

@alexanderniebuhr
Copy link
Member Author

the team should add some infra to test these utilities.

I agree, just created #8960, so it does not get out of sight.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left my tiny suggestion! 🙌

.changeset/odd-maps-glow.md Outdated Show resolved Hide resolved
@alexanderniebuhr alexanderniebuhr force-pushed the nbhr/feat_underscore-redirects_add_base_to_input_paths branch 2 times, most recently from 53d62d0 to 24d67b8 Compare November 1, 2023 13:56
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Bjorn Lu <34116392+bluwy@users.noreply.github.com>
@alexanderniebuhr alexanderniebuhr force-pushed the nbhr/feat_underscore-redirects_add_base_to_input_paths branch from 24d67b8 to 596df58 Compare November 1, 2023 13:57
@alexanderniebuhr alexanderniebuhr merged commit 6bc2153 into main Nov 1, 2023
15 checks passed
@alexanderniebuhr alexanderniebuhr deleted the nbhr/feat_underscore-redirects_add_base_to_input_paths branch November 1, 2023 15:01
@astrobot-houston astrobot-houston mentioned this pull request Nov 1, 2023
natemoo-re pushed a commit that referenced this pull request Nov 22, 2023
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Bjorn Lu <34116392+bluwy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants