Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(netlify): add base fixture and prepare test (#45) #49

Merged

Conversation

florian-lefebvre
Copy link
Member

Changes

  • Add fixture folder

Testing

Prepared test as well but commented out the failing part

Docs

N/A

cc @alexanderniebuhr

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2023

⚠️ No Changeset found

Latest commit: c49c8f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alexanderniebuhr
Copy link
Member

@florian-lefebvre thank you so much

@alexanderniebuhr
Copy link
Member

alexanderniebuhr commented Nov 2, 2023

@florian-lefebvre can you reenable the test, so we can validate if acf4c82 fixed the issue.

@florian-lefebvre
Copy link
Member Author

You need to update the branch I think

@alexanderniebuhr
Copy link
Member

@florian-lefebvre can you double check the RegExp in the test, AFAICT the output is correct now, but the test still fails.

@florian-lefebvre
Copy link
Member Author

@alexanderniebuhr it was a stupid indentation error!

Copy link
Member

@alexanderniebuhr alexanderniebuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@florian-lefebvre thanks for helping with this test!

@alexanderniebuhr alexanderniebuhr merged commit 3540bd2 into withastro:main Nov 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants