ice-restart: fix functionality #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fippo
force-pushed
the
restart-fix
branch
3 times, most recently
from
cfb242c
to
d2dff30
Compare
fippo
commented
Apr 4, 2022
| @@ -30,7 +30,7 @@ | |||
| ], | |||
| "devDependencies": { | |||
| "chai": "^4.3.6", | |||
| "chromedriver": "^98.0.1", | |||
There was a problem hiding this comment.
drive-by fix, otherwise chromedriver gets stuck on a version incompatible with the chrome version that gets installed
fippo
commented
Apr 5, 2022
| @@ -15,7 +15,7 @@ let driver; | |||
| const path = '/src/content/datachannel/filetransfer/index.html'; | |||
| const url = `${process.env.BASEURL ? process.env.BASEURL : ('file://' + process.cwd())}${path}`; | |||
|
|
|||
| describe('datachannel basic', () => { | |||
| describe('datachannel filetransfer', () => { | |||
fippo
force-pushed
the
restart-fix
branch
3 times, most recently
from
a5ce2be
to
6dc868a
Compare
alvestrand
approved these changes
Apr 6, 2022
by listening to the transport selectedcandidatepairchange event. This sample has been relying on the somewhat buggy but useful behavior of the "legacy" iceconnectionstatechange firing a "connected" event even if the previous state was already connected. This behavior is no longer supported in the spec iceconnectionstatechange event. Alternatively listen to the selectedcandidatepairchange event and determine the availability of new candidates based on that
a total 5 minute job timeout should be enough and will prevent jobs from hanging for 30 minutes. Increase the mocha per-test timeout to five seconds (from the default 2s)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by listening to the transport selectedcandidatepairchange event.
This sample has been relying on the somewhat buggy but useful behavior
of the "legacy" iceconnectionstatechange firing a "connected" event even
if the previous state was already connected.
This behavior is no longer supported in the spec iceconnectionstatechange
event. Alternatively listen to the selectedcandidatepairchange event and
determine the availability of new candidates based on that