Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ice-restart: fix functionality #1534

Merged
merged 3 commits into from
Apr 6, 2022
Merged

ice-restart: fix functionality #1534

merged 3 commits into from
Apr 6, 2022

Commits on Apr 6, 2022

  1. ice-restart: fix functionality 

    by listening to the transport selectedcandidatepairchange event.
This sample has been relying on the somewhat buggy but useful behavior
of the "legacy" iceconnectionstatechange firing a "connected" event even
if the previous state was already connected.

This behavior is no longer supported in the spec iceconnectionstatechange
event. Alternatively listen to the selectedcandidatepairchange event and
determine the availability of new candidates based on that
    @fippo
    fippo committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    ef0b55f View commit details
    Browse the repository at this point in the history

  2. fix test description

    @fippo
    fippo committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    90c750b View commit details
    Browse the repository at this point in the history

  3. specify test timeouts 

    a total 5 minute job timeout should be enough and will prevent jobs
from hanging for 30 minutes.
Increase the mocha per-test timeout to five seconds (from the default 2s)
    @fippo
    fippo committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    b83125d View commit details
    Browse the repository at this point in the history