Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera exposure example #1533

Merged
merged 9 commits into from
Apr 6, 2022
Merged

Conversation

sjkummer
Copy link
Contributor

@sjkummer sjkummer commented Apr 1, 2022

Description
Added an example for exposure control based on getusermedia/ptz.
Tested on Windows with Logitech Brio and C525 using official Logitech drivers.

Purpose

  • The support for exposure controls differs between cameras, platforms and drivers. It's nice to have an easy way to test it.
  • Keep @fippo busy 😉

@google-cla
Copy link

google-cla bot commented Apr 1, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@sjkummer sjkummer marked this pull request as draft April 1, 2022 16:10
@sjkummer sjkummer marked this pull request as ready for review April 1, 2022 17:01
@fippo
Copy link
Collaborator

fippo commented Apr 1, 2022

The more samples the merrier!

eslint should be able to fix most errors on its own

src/content/getusermedia/exposure/index.html Outdated Show resolved Hide resolved
src/content/getusermedia/exposure/js/main.js Outdated Show resolved Hide resolved
src/content/getusermedia/exposure/js/main.js Outdated Show resolved Hide resolved
@sjkummer
Copy link
Contributor Author

sjkummer commented Apr 5, 2022

eslint should be able to fix most errors on its own

eslint should be fine now

@sjkummer
Copy link
Contributor Author

sjkummer commented Apr 5, 2022

Seems like the chromedriver version is outdated in package.json:
"chromedriver": "^98.0.1",

CI:
Current browser version is 100.0.4896.75 with binary path browsers/bin/chrome-stable

Should I change that, or would you prefer to fix that in a separate PR? @fippo

@fippo
Copy link
Collaborator

fippo commented Apr 5, 2022

that, along with some flakyness is fixed in #1534

Copy link
Collaborator

@fippo fippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (now who gets to fix the reported bug.. :-))

@fippo fippo merged commit 91f7b01 into webrtc:gh-pages Apr 6, 2022
@pgurusami
Copy link

@sjkummer
Tried running in macOs and it reports that the controls are not available.
But with the same webcam, I am able to adjust the settings in Windows system.
your inputs will be helpful

@fippo
Copy link
Collaborator

fippo commented Oct 18, 2024

Maybe @beaufortfrancois knows the status of camera exposure on MacOS...

@beaufortfrancois
Copy link
Contributor

UVC Controls on Chrome for macOS are currently disabled sadly: https://source.chromium.org/chromium/chromium/src/+/main:media/capture/video/mac/uvc_control_mac.mm;l=29;drc=2b892bc0f2a92c512d433f73a68bd1c41c82131b
I'm not aware of plans to re-enable them by default. @handellm may know more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants