Skip to content

Remove the support of null value in newShape parameter of reshape build method #388

@huningxin

Description

@huningxin

WebNN reshape op build method currently supports a special null value in newShape array that instructs the implementation to compute the size of the dimension with the value null so that the total size remains constant.

In PR review #367 (comment), @fwdr proposed WebNN should only support the concrete values in newShape because this can be easily handled by framework through shape inference. Thanks Dwyane!

Though also, is this some behavior that could be easily resolved by the frameworks calling into WebNN, since presumably they already know the shapes along the way (shape inference) and could instead pass concrete values to WebNN?

I think this would also help simplify the implementation.

/cc @wacky6

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions