Skip to content

Update newShape with null value for reshape operation #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
huningxin merged 1 commit into from
Apr 11, 2023
Merged

Update newShape with null value for reshape operation #367

huningxin merged 1 commit into from
Apr 11, 2023

Conversation

@BruceDai
Copy link
Contributor

@BruceDai BruceDai commented Mar 23, 2023 •
edited by pr-preview bot
Loading

@huningxin @anssiko PTAL, thanks.

Preview | Diff

@BruceDai BruceDai force-pushed the update_shape_with_null branch from a8638c5 to db53c2f Compare March 23, 2023 09:37
@anssiko
Copy link
Member

anssiko commented Mar 23, 2023

Is there a corresponding issue that this PR proposes to fix?

@BruceDai
Copy link
Contributor Author

BruceDai commented Mar 24, 2023

Is there a corresponding issue that this PR proposes to fix?

Yes, this pr is also to fix #289, thanks.

@anssiko
Copy link
Member

anssiko commented Mar 24, 2023

@wacky6 PTAL if this PR fixes issue #289 you identified.

Thanks @BruceDai for the PR!

@anssiko anssiko requested a review from huningxin March 24, 2023 10:46
@BruceDai BruceDai mentioned this pull request Mar 31, 2023
Merged
@fdwr
Copy link
Collaborator

fdwr commented Apr 5, 2023 •
edited
Loading

@BruceDai : Yeah, I like null more than I do -1 as a sort of wildcard - thanks (and that enables using tensors greater than 2147483647 elements, per the issue you linked to).

Though also, is this some behavior that could be easily resolved by the frameworks calling into WebNN, since presumably they already know the shapes along the way (shape inference) and could instead pass concrete values to WebNN?

@huningxin huningxin mentioned this pull request Apr 10, 2023
Closed
@huningxin
Copy link
Contributor

huningxin commented Apr 11, 2023

Thanks for the review and approvals. Let's merge this PR.

@huningxin huningxin merged commit 5ad1b5d into webmachinelearning:main Apr 11, 2023
github-actions bot added a commit that referenced this pull request Apr 11, 2023
@huningxin @github-actions
Merge pull request #367 from BruceDai/update_shape_with_null
71d60cf 
SHA: 5ad1b5d
Reason: push, by huningxin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@anssiko
Copy link
Member

anssiko commented Apr 11, 2023

@dontcallmedom CRD was expected but deploy to W3C says skipped: https://github.com/webmachinelearning/webnn/actions/runs/4499106496/jobs/7916543577#step:3:994

What needs to be updated in https://github.com/webmachinelearning/webnn/blob/main/.github/workflows/auto-publish.yml to resume publications to TR?

@dontcallmedom
Copy link
Contributor

dontcallmedom commented Apr 11, 2023

The relevant failure is https://github.com/webmachinelearning/webnn/actions/runs/4665203838/jobs/8258293140#step:3:779 - there seems to be still a bug with the SOTD boilerplate, filed
speced/bikeshed-boilerplate#38 to fix

@huningxin huningxin mentioned this pull request May 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huningxin huningxin huningxin approved these changes

@fdwr fdwr fdwr approved these changes

@wchao1115 wchao1115 wchao1115 approved these changes

+1 more reviewer

@wacky6 wacky6 wacky6 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@BruceDai @anssiko @fdwr @huningxin @dontcallmedom @wchao1115 @wacky6