Bug fix: Remove null value support in reshape()'s newShape parameter #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huningxin
approved these changes
Jan 17, 2024
Contributor
huningxin
left a comment
huningxin
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix!
As noted in issue #388, the reshape op build method currently supports a special null value in newShape array that instructs the implementation to compute the size of the dimension with the value null so that the total size remains constant. @fwdr proposed WebNN should only support the concrete values in newShape because this can be easily handled by framework through shape inference It appears this change has already landed in the Chromium implementation and WPTs. Fixes #388
Contributor
Author
|
Rebased - Preview | Diff now available. |
anssiko
approved these changes
Jan 18, 2024
wchao1115
approved these changes
Jan 20, 2024
fdwr
pushed a commit
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in issue #388, the reshape op build method currently supports a special null value in newShape array that instructs the implementation to compute the size of the dimension with the value null so that the total size remains constant. @fwdr proposed WebNN should only support the concrete values in newShape because this can be easily handled by framework through shape inference
It appears this change has already landed in the Chromium implementation and WPTs.
Fixes #388
Preview | Diff