Use MaxAttemptsReachedOnReconnectingError similar to v1.x

[Muhammad-Altabba]

Description

Fixes #5889

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist for 1.x:

• I have selected the correct base branch.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no new warnings.
• Any dependent changes have been merged and published in downstream modules.
• I ran npm run dtslint with success and extended the tests and types if necessary.
• I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
• I ran npm run build with success.
• I have tested the built dist/web3.min.js in a browser.
• I have tested my code on the live network.
• I have checked the Deploy Preview and it looks correct.
• I have updated the CHANGELOG.md file in the root folder.

Checklist for 4.x:

• I have selected the correct 4.x base branch.
• Within the description, the feature or issue is discussed in detail or an issue is linked.
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas.
• I have added any required tests for the changes I made
• I have made corresponding changes to the documentation
• Any dependent changes have been merged and published in downstream modules.
• I ran yarn successfully
• I ran yarn lint successfully
• I ran yarn build:web successfully
• I ran yarn test:unit successfully
• I ran yarn test:integration successfully
• I ran compile:contracts successfully
• I have tested my code.
• I have updated the corresponding CHANGELOG.md file in the packages I have edited.

[github-actions]

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset	Old size	New size	Diff	Diff %
Total	1.18 MB	1.06 MB	-119 KB	-9.90%

View detailed bundle breakdown

Added

Asset	Old size	New size	Diff	Diff %
../lib/eth.exports.d.ts.map	0	358 bytes	358 bytes	-
../lib/eth.exports.d.ts	0	321 bytes	321 bytes	-
../lib/providers.exports.d.ts.map	0	292 bytes	292 bytes	-
../lib/providers.exports.d.ts	0	238 bytes	238 bytes	-

Removed

No assets were removed

Bigger

Asset	Old size	New size	Diff	Diff %
../lib/index.d.ts	77 bytes	899 bytes	822 bytes	1067.53%
../lib/index.d.ts.map	155 bytes	919 bytes	764 bytes	492.90%

Smaller

Asset	Old size	New size	Diff	Diff %
web3.min.js	1.17 MB	1.05 MB	-121 KB	-10.17%
../lib/types.d.ts	1.92 KB	1.68 KB	-253 bytes	-12.84%
../lib/types.d.ts.map	1.75 KB	1.51 KB	-241 bytes	-13.46%

Unchanged

Asset	Old size	New size	Diff	Diff %
../lib/accounts.d.ts	3.42 KB	3.42 KB	0	0.00%
../lib/abi.d.ts	1020 bytes	999 bytes	-18 bytes	-1.77%
../lib/web3.d.ts	842 bytes	842 bytes	0	0.00%
../lib/web3.d.ts.map	693 bytes	694 bytes	1 bytes	0.14%
../lib/accounts.d.ts.map	528 bytes	528 bytes	0	0.00%
../lib/version.d.ts.map	140 bytes	140 bytes	0	0.00%
../lib/abi.d.ts.map	124 bytes	124 bytes	0	0.00%
../lib/version.d.ts	97 bytes	97 bytes	0	0.00%

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	84029a2
Status:	✅  Deploy successful!
Preview URL:	https://d106f270.web3-js-docs.pages.dev
Branch Preview URL:	https://feature-5889-keep-emitting-t.web3-js-docs.pages.dev

View logs

[codecov]

Codecov Report

Merging #5894 (84029a2) into 4.x (36bd823) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Additional details and impacted files

@@            Coverage Diff             @@
##              4.x    #5894      +/-   ##
==========================================
+ Coverage   80.85%   80.86%   +0.01%     
==========================================
  Files         136      136              
  Lines        5901     5900       -1     
  Branches     1537     1537              
==========================================
  Hits         4771     4771              
+ Misses       1130     1129       -1     

Flag	Coverage Δ
UnitTests	80.86% <66.66%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
web3	∅ <ø> (∅)
web3-core	∅ <ø> (∅)
web3-errors	∅ <ø> (∅)
web3-eth	∅ <ø> (∅)
web3-eth-abi	∅ <ø> (∅)
web3-eth-accounts	∅ <ø> (∅)
web3-eth-contract	∅ <ø> (∅)
web3-eth-ens	∅ <ø> (∅)
web3-eth-iban	∅ <ø> (∅)
web3-eth-personal	∅ <ø> (∅)
web3-net	∅ <ø> (∅)
web3-providers-http	∅ <ø> (∅)
web3-providers-ipc	∅ <ø> (∅)
web3-providers-ws	∅ <ø> (∅)
web3-rpc-methods	∅ <ø> (∅)
web3-utils	∅ <ø> (∅)
web3-validator	∅ <ø> (∅)

[luu-alex]

https://github.com/web3/web3.js/runs/11848321915 codecov seems to be failing, otherwise PR LGTM

[Muhammad-Altabba]

Thanks @luu-alex ,
Actually, this is tested twice inside web3-providers-ws and web3-providers-ipc. But CodeCov does not check across packages. So, I think it is safe to ignore it. Or what do you think?

[nikoulai]

couldn't we have a dedicated test in web3-utils for that?

[Muhammad-Altabba]

Actually, we can. But it will require a complex scenario that is already tested twice with IpcProvider and WebSocketProvider. So, writing the test will be just time-consuming, I think 😊 .

[jdevcs]

Actually, this is tested twice inside web3-providers-ws and web3-providers-ipc. But CodeCov does not check across packages

currently codecov is only checking unit-testing inside packages and not counting any coverage for tests across packages ( integration tests )

[nikoulai]

couldn't we have a dedicated test in web3-utils for that?

[jdevcs]

lgtm, except change request above.