Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MaxAttemptsReachedOnReconnectingError similar to v1.x #5894

Merged
merged 15 commits into from
Mar 9, 2023
Merged

Use MaxAttemptsReachedOnReconnectingError similar to v1.x #5894

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f8483b3
pass `_socketOptions` from IpcProvider constructor to the underlying …
Muhammad-Altabba Mar 6, 2023
9ba98e2
move a comment to its correct position at `SocketProvider`
Muhammad-Altabba Mar 6, 2023
7e96e84
expose the getter of `SocketConnection` from `SocketProvider`.
Muhammad-Altabba Mar 6, 2023
e450485
update CHANGELOG.md files
Muhammad-Altabba Mar 6, 2023
fd9dd2c
add extremely simple unit test for SocketProvider
Muhammad-Altabba Mar 6, 2023
9800deb
removed unused import at a test
Muhammad-Altabba Mar 6, 2023
b74a281
use `MaxAttemptsReachedOnReconnectingError` similar to v1.x
Muhammad-Altabba Mar 6, 2023
6e84af7
modify CHANGELOG.md
Muhammad-Altabba Mar 6, 2023
9e1d763
Merge branch 'feature/5887/the-options-passed-to-the-ipcprovider-is-n…
Muhammad-Altabba Mar 6, 2023
8526464
Merge branch '4.x' into feature/5889/keep-emitting-the-error-as-an-ob…
Muhammad-Altabba Mar 7, 2023
ea8fbcb
fix a test
Muhammad-Altabba Mar 7, 2023
bc74b2b
Merge branch 'feature/5889/keep-emitting-the-error-as-an-object-for-m…
Muhammad-Altabba Mar 7, 2023
1e93e01
Merge branch '4.x' into feature/5889/keep-emitting-the-error-as-an-ob…
Muhammad-Altabba Mar 9, 2023
ea897ec
Merge branch '4.x' into feature/5889/keep-emitting-the-error-as-an-ob…
Muhammad-Altabba Mar 9, 2023
84029a2
edit CHAINGLOG.md
Muhammad-Altabba Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
edit CHAINGLOG.md
  • Loading branch information
@Muhammad-Altabba
Muhammad-Altabba authored Mar 9, 2023
commit 84029a2fb559eb21a1296d1fae314fbd58064d92
2 changes: 1 addition & 1 deletion packages/web3-errors/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed

- The abstract class `Web3Error` is renamed to `BaseWeb3Error` (#5771)
- Using `MaxAttemptsReachedOnReconnectingError` with the same message for 1.x but also adding the `maxAttempts` (#5894)

### Added

- Added error class `InvalidMethodParamsError` and error code `ERR_INVALID_METHOD_PARAMS = 207` (#5824)
- Using `MaxAttemptsReachedOnReconnectingError` with the same message for 1.x but also adding the `maxAttempts` (#5894)