This repository was archived by the owner on Mar 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Add guide for the breaking changes for Iban and IpcProvider #5899
Merged
Muhammad-Altabba
merged 28 commits into
4.x
from
feature/5737/guide-breaking-changes-documenation-for-iban-and-ipcprovider
Mar 13, 2023
Merged
Add guide for the breaking changes for Iban and IpcProvider #5899
Muhammad-Altabba
merged 28 commits into
4.x
from
feature/5737/guide-breaking-changes-documenation-for-iban-and-ipcprovider
Mar 13, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…connection + rename `_providerOptions` to `_socketOptions`
…ot-passed-to-the-constructor-of-the-underlying-socket-object' into feature/5889/keep-emitting-the-error-as-an-object-for-maximum-number-of-reconnect-attempts-reached
Deploying with
|
| Latest commit: |
d586feb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://22c1b941.web3-js-docs.pages.dev |
| Branch Preview URL: | https://feature-5737-guide-breaking-.web3-js-docs.pages.dev |
…ion-for-iban-and-ipcprovider
…an-and-ipcprovider' of https://github.com/ChainSafe/web3.js into feature/5737/guide-breaking-changes-documenation-for-iban-and-ipcprovider
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #5899 +/- ##
==========================================
+ Coverage 81.00% 81.01% +0.01%
==========================================
Files 137 137
Lines 5981 5985 +4
Branches 1573 1573
==========================================
+ Hits 4845 4849 +4
Misses 1136 1136
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded
Removed No assets were removed Bigger
Smaller
Unchanged
|
…ion-for-iban-and-ipcprovider
…ion-for-iban-and-ipcprovider
jdevcs
reviewed
Mar 9, 2023
jdevcs
reviewed
Mar 9, 2023
jdevcs
reviewed
Mar 9, 2023
docs/docs/guides/web3_migration_guide/providers_migration_guide.md
Outdated
Show resolved
Hide resolved
jdevcs
reviewed
Mar 9, 2023
jdevcs
reviewed
Mar 9, 2023
Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com>
…aking-changes-documenation-for-iban-and-ipcprovider
…an-and-ipcprovider' of https://github.com/ChainSafe/web3.js into feature/5737/guide-breaking-changes-documenation-for-iban-and-ipcprovider
…ion-for-iban-and-ipcprovider
jdevcs
approved these changes
Mar 10, 2023
avkos
approved these changes
Mar 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5737
Type of change
Checklist for 1.x:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildwith success.dist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.Checklist for 4.x:
yarnsuccessfullyyarn lintsuccessfullyyarn build:websuccessfullyyarn test:unitsuccessfullyyarn test:integrationsuccessfullycompile:contractssuccessfullyCHANGELOG.mdfile in the packages I have edited.