Skip to content

test: fix cjs js api tests #9868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

test: fix cjs js api tests #9868

merged 1 commit into from
Apr 1, 2025

Conversation

Timeless0911
Copy link
Contributor

Summary

Should use require instead of import to avoid some transformation behaviour.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Timeless0911 Timeless0911 requested a review from SoonIter April 1, 2025 09:26
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 1, 2025
Copy link

netlify bot commented Apr 1, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 37262be
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67ebb14b4b9d6c000863a631
😎 Deploy Preview https://deploy-preview-9868--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Apr 1, 2025

CodSpeed Performance Report

Merging #9868 will not alter performance

Comparing fix/cjs-require-test (37262be) with main (73de9b4)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 8 untouched benchmarks

@SoonIter SoonIter merged commit 9baf996 into main Apr 1, 2025
35 checks passed
@SoonIter SoonIter deleted the fix/cjs-require-test branch April 1, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants