Skip to content

Commit 9baf996

Browse files
authored
test: fix cjs js api tests (#9868)
1 parent 73de9b4 commit 9baf996

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed
Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,22 @@
1-
import rspackCjsRequire, {
2-
rspack as rspackCjsNamedRequire
3-
} from "@rspack/core";
1+
const rspackCjsDefaultRequire = require("@rspack/core");
2+
const { rspack: rspackCjsNamedRequire } = require("@rspack/core");
43
import assert from "node:assert";
54

65
type IsFunction<T> = T extends (...args: any[]) => any ? true : false;
76

87
// https://github.com/web-infra-dev/rspack/issues/8095
98
describe("js-api-type should be correct when requiring from @rspack/core", () => {
109
it.concurrent("cjs default require", async () => {
11-
// const rspack = require('@rspack/core')
12-
type Truthy = IsFunction<typeof rspackCjsRequire>;
10+
type Truthy = IsFunction<typeof rspackCjsDefaultRequire>;
1311
const truthy: Truthy = true;
1412
truthy;
15-
assert(rspackCjsNamedRequire.BannerPlugin);
16-
assert(typeof rspackCjsNamedRequire === "function");
17-
const compiler = rspackCjsNamedRequire({});
13+
assert(rspackCjsDefaultRequire.BannerPlugin);
14+
assert(typeof rspackCjsDefaultRequire === "function");
15+
const compiler = rspackCjsDefaultRequire({});
1816
assert(compiler);
1917
});
2018

2119
it.concurrent("cjs named require", async () => {
22-
// const { rspack } = require('@rspack/core')
2320
type Truthy = IsFunction<typeof rspackCjsNamedRequire>;
2421
const truthy: Truthy = true;
2522
truthy;
@@ -31,6 +28,6 @@ describe("js-api-type should be correct when requiring from @rspack/core", () =>
3128

3229
it.concurrent("rspack.default should not exist in cjs require", async () => {
3330
assert(!(rspackCjsNamedRequire as any).default);
34-
assert(!(rspackCjsRequire as any).default);
31+
assert(!(rspackCjsDefaultRequire as any).default);
3532
});
3633
});

0 commit comments

Comments
 (0)