Skip to content

test: fix cjs js api tests #9868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

test: fix cjs js api tests #9868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions packages/rspack-cli/tests/api/type/js-api-cjs.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,22 @@
import rspackCjsRequire, {
rspack as rspackCjsNamedRequire
} from "@rspack/core";
const rspackCjsDefaultRequire = require("@rspack/core");
const { rspack: rspackCjsNamedRequire } = require("@rspack/core");
import assert from "node:assert";

type IsFunction<T> = T extends (...args: any[]) => any ? true : false;

// https://github.com/web-infra-dev/rspack/issues/8095
describe("js-api-type should be correct when requiring from @rspack/core", () => {
it.concurrent("cjs default require", async () => {
// const rspack = require('@rspack/core')
type Truthy = IsFunction<typeof rspackCjsRequire>;
type Truthy = IsFunction<typeof rspackCjsDefaultRequire>;
const truthy: Truthy = true;
truthy;
assert(rspackCjsNamedRequire.BannerPlugin);
assert(typeof rspackCjsNamedRequire === "function");
const compiler = rspackCjsNamedRequire({});
assert(rspackCjsDefaultRequire.BannerPlugin);
assert(typeof rspackCjsDefaultRequire === "function");
const compiler = rspackCjsDefaultRequire({});
assert(compiler);
});

it.concurrent("cjs named require", async () => {
// const { rspack } = require('@rspack/core')
type Truthy = IsFunction<typeof rspackCjsNamedRequire>;
const truthy: Truthy = true;
truthy;
Expand All @@ -31,6 +28,6 @@ describe("js-api-type should be correct when requiring from @rspack/core", () =>

it.concurrent("rspack.default should not exist in cjs require", async () => {
assert(!(rspackCjsNamedRequire as any).default);
assert(!(rspackCjsRequire as any).default);
assert(!(rspackCjsDefaultRequire as any).default);
});
});
Loading