-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish artifacts for test fixtures #1201
Comments
Related to #1171. |
I see some test fixtures snapshot artifacts here: So this looks promising :-) @liblit would |
I believe so. Looking at the Maven metadata for the latest <snapshotVersion>
<classifier>test-fixtures</classifier>
<extension>jar</extension>
<value>1.6.0-20230115.154234-25</value>
<updated>20230115154234</updated>
</snapshotVersion> A better test would be to use these newly available test fixtures in a non-WALA project. OK: done. plugins { id("java") }
repositories.maven { url = uri("https://oss.sonatype.org/content/repositories/snapshots/") }
dependencies { implementation("com.ibm.wala:com.ibm.wala.core:1.6.0-SNAPSHOT:test-fixtures") } The best test of all would be to have @khatchad use the test fixtures. I believe that he already has some projects that rely on test-fixtures material. Those projects should now be able to pull what they need from the Sonatype snapshots repository in the style that I showed above in my example |
Thanks @liblit. I'll give it a shot. The wala/ML project is using Maven, so I'll need to translate it from the Gradle above. |
Per wala/WALA#1201 (comment). Will try the test fixture build from an online repo.
I removed the custom WALA build, but the test fixtures are now coming from the cache. I'll see if I can flush that. |
OK, got the build to fail. Now that the custom build is gone, it looks like the test fixtures are being downloaded from a few different places (see: https://app.travis-ci.com/github/ponder-lab/ML/builds/259768708#L1351). It would seem that I need to change the WALA version to use the 1.6.0 snapshot version in order to get the newly released ones. |
Yes. The test fixtures that we are releasing are on the current WALA master branch, which produces 1.6.0-SNAPSHOT artifacts. We have not back-ported releasing of test fixtures to 1.5.x, and have no plans to do so. |
If it's helpful I can cut a 1.6.0 release in a few days, @khatchad |
Thanks, @msridhar. It looks like there's a few extra steps to enable snapshot dependencies. I'll take a hack at it and let yi9y know. |
@khatchad if I release 1.6.0 you won't have to worry about enabling snapshot dependencies in wala/ML. Also, for build reproducibility, it'd be best if we could have wala/ML depend on a released version of WALA, not on changing snapshots. So, if you can wait a few days, I can release WALA 1.6.0 and then you can update wala/ML to rely on that version and (hopefully) not need to build WALA from source anymore. |
Sounds good, @msridhar. |
Artifacts relating to test fixtures are not currently published to the remote Sonatype repository. We should publish these too, though. See further discussion here.
The text was updated successfully, but these errors were encountered: