Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.6.0 (including test fixtures) #1211

Closed
khatchad opened this issue Jan 17, 2023 · 13 comments
Closed

Release 1.6.0 (including test fixtures) #1211

khatchad opened this issue Jan 17, 2023 · 13 comments

Comments

@khatchad
Copy link
Contributor

          @khatchad if I release 1.6.0 you won't have to worry about enabling snapshot dependencies in wala/ML.  Also, for build reproducibility, it'd be best if we could have wala/ML depend on a released version of WALA, not on changing snapshots.  So, if you can wait a few days, I can release WALA 1.6.0 and then you can update wala/ML to rely on that version and (hopefully) not need to build WALA from source anymore.

Originally posted by @msridhar in #1201 (comment)

@msridhar
Copy link
Member

Version 1.6.0 is now released.

@msridhar
Copy link
Member

It looks like the test fixtures artifacts are present as well, e.g., you can see them here for wala.core:

https://repo1.maven.org/maven2/com/ibm/wala/com.ibm.wala.core/1.6.0/

@khatchad can you confirm now that for wala/ML you can pull the 1.6.0 artifacts just from Maven Central and complete the build, so WALA no longer needs to be built from source?

@khatchad
Copy link
Contributor Author

ponder-lab/ML@ec071ea

@khatchad
Copy link
Contributor Author

@liblit
Copy link
Contributor

liblit commented Jan 21, 2023

@khatchad: do these links you're posting mean "Yes, it works" or "No, it does not work"?

@khatchad
Copy link
Contributor Author

Means: "in progress."

@khatchad
Copy link
Contributor Author

The build passed, so it works!

@khatchad
Copy link
Contributor Author

I'll merge it up and open a PR on github.com/wala/ML. Thanks!

@khatchad
Copy link
Contributor Author

We can also see from this changeset that the custom WALA build has been removed.

@liblit
Copy link
Contributor

liblit commented Jan 21, 2023

I can't speak for @msridhar, but I don't need minute-by-minute progress reports. If the final answer is "Yes, it works", then that's all I need to know here.

And...apparently it works. Hooray! I hope that this makes life easier for you to keep wala/ML building cleanly. Getting those test-fixtures components released was overdue. Thanks for pushing us to make it happen.

@khatchad
Copy link
Contributor Author

Thanks for adding the test fixtures, @liblit!

@khatchad
Copy link
Contributor Author

This issue can be closed.

@liblit
Copy link
Contributor

liblit commented Jan 21, 2023

It already is closed, @khatchad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants