Get it building #23

khatchad · 2022-12-25T00:37:41Z

Updating and documenting the build process.

Based on https://github.com/Anemone95/wala-python/blob/709a3047eab5ed0c3a7889f7478566ae0dd9ea7a/python-frontend/pom.xml

Based on maldil@705e59f

We're getting it from the parent pom.

From https://github.com/github/gitignore/blob/4488915eec0b3a45b5c63ead28f286819c0917de/Global/Vim.gitignore

It would seem that the test files are in the normal source directories.

Not sure if it's completely necessary.

The token isn't working.

This reverts commit 5953caf.

I think it is included in the deployment.

Different projects have different build and resource directories.

Buildship seemed to do this automatically.

… directory?

It's timing out.

This seems to be the project standard.

This reverts commit 9355100. It doesn't seem to work.

Added an m2e property not to set the source folder as a test source. The problem is that Eclipse will not export test source packages, but this package is *both* a test source and normal source.

khatchad · 2023-01-05T20:59:44Z

You may want to review the files by ignoring whitespace.

khatchad · 2023-01-05T21:49:27Z

Good to go here. I had to skip one test, namely, the ServerTest. I didn't fix the J2EE stuff, and that test was hanging.

khatchad · 2023-01-05T21:50:41Z

The J2EE module was not part of the original (automated) build:

ML/pom.xml

Lines 24 to 33 in 0543c10

    
           <modules> 
        
             <module>com.ibm.wala.cast.python</module> 
        
             <module>com.ibm.wala.cast.python.jython</module> 
        
             <module>com.ibm.wala.cast.python.jython3</module> 
        
             <module>com.ibm.wala.cast.python.test</module> 
        
             <module>com.ibm.wala.cast.python.jython.test</module> 
        
             <module>com.ibm.wala.cast.python.jython3.test</module> 
        
             <module>com.ibm.wala.cast.python.ml</module> 
        
             <module>com.ibm.wala.cast.python.ml.test</module> 
        
           </modules>

Perhaps this was being test manually in the past.

msridhar

Overall this looks fine to me. I will approve with a relatively cursory review since this is a significant improvement over what we had before. I just have one comment to address

msridhar · 2023-01-08T18:01:12Z

CONTRIBUTING.md

+1. Build and deploy WALA to your local maven repository. This is necessary because the test JARs are not published on Maven Central: `./gradlew publishToMavenLocal`.
+    1. If you run into [this issue](https://github.com/wala/WALA/issues/1173), try: `./gradlew publishToMavenLocal -x signRemotePublication`.


Can we update these instructions in light of the updates on the corresponding WALA issue?

Yes, but it would be different depending whether the rest JARs are released. Do we have those for 1.5.9 or does a new release need to be cut?

I think even for 1.5.9, just running ./gradlew publishLocalPublicationToMavenLocal should work without requiring signing; see here. Does it work for you?

Yes, but it would be ideal to have these JARs in maven local instead of building WALA locally.

Sure, but that won't happen until after we fix the relevant issues and cut the next release (timeline unclear). In the meantime, if we want to merge this, we should have the instructions be correct for whatever release works for this repo.

Right. Done.

Is there an issue on http://github.com/wala/WALA that I can track to the test JARs to be released? I'll create an issue on this slide and block on that.

There is wala/WALA#1201. After that is fixed, I would have to cut a release (which should be easy).

Oh, yes, I also forgot I had wala/WALA#1171.

Per wala/WALA#1173 (comment), using the `publishLocalPublicationToMavenLocal` task instead of the more obvious `publishToMavenLocal` task.

Per wala/WALA#1173 (comment), usinmg the `publishLocalPublicationToMavenLocal` task instead of the more obvious `publishToMavenLocal` task.

msridhar

LGTM, let's merge

khatchad added 15 commits December 20, 2022 18:18

Some work on Maven infrastructure.

86e9371

Based on https://github.com/Anemone95/wala-python/blob/709a3047eab5ed0c3a7889f7478566ae0dd9ea7a/python-frontend/pom.xml

Add gitignore.

8d64b60

Upgrade to WALA 1.5.8.

a2158dc

Based on maldil@705e59f

Remove version.

4f3fc62

We're getting it from the parent pom.

Fix version.

203c36b

Ignore Vim intermediate/temporary files.

4938e62

From https://github.com/github/gitignore/blob/4488915eec0b3a45b5c63ead28f286819c0917de/Global/Vim.gitignore

Start contribution document.

ab965f9

Metadat updates.

eada615

Ignore gradle output.

839a93f

Remove the test scope.

293be7d

It would seem that the test files are in the normal source directories.

Update JUnit.

438bf90

Add Eclipse Gradle metadata.

c02d142

Not sure if it's completely necessary.

Modify building instructions.

6f00d6e

More Eclipse Gradle metadata.

ea6ede2

Ignore maven intermediate output.

60d955c

khatchad mentioned this pull request Dec 25, 2022

com.ibm.wala.cast.util.test.TestCallGraphShape no longer being packaged in released JARs? wala/WALA#1171

Closed

khatchad added 14 commits January 4, 2023 16:58

Add workaround for wala/WALA#1173.

fe069ec

Modernize the Travis CI build.

1115846

Need more history.

b1b15e4

Remove deploy section.

7b1a9ee

The token isn't working.

Add slack notification.

9355100

Add gradle caches.

9bc3348

Make it more readable.

5953caf

Revert "Make it more readable."

80fc617

This reverts commit 5953caf.

Remove the WALA build step.

08e3e96

I think it is included in the deployment.

Remove sudo key.

25cf203

Remove space.

4bd3f0b

Remove unnecessary verison.

eeb6de5

Decentralize build.

3ae56bd

Different projects have different build and resource directories.

Update Eclipse metadata.

9c40126

khatchad added 10 commits January 5, 2023 11:45

Add missing intraproject module dependency.

da43f9f

Remove obselete Gradle metadata?

0d978e1

Buildship seemed to do this automatically.

For com.ibm.wala.cast.python.test, "source" is both a source and test…

3ac3053

… directory?

Exclude the server test for now.

41e8ef6

It's timing out.

Increase antlr version.

3a91ffc

Ignore test in the source code instead.

26e7eeb

This seems to be the project standard.

Add test reporting.

315635c

Revert "Add slack notification."

6da6870

This reverts commit 9355100. It doesn't seem to work.

Remove tab character.

42fa14a

Make it compile in Eclipse.

6bc19b1

Added an m2e property not to set the source folder as a test source. The problem is that Eclipse will not export test source packages, but this package is *both* a test source and normal source.

khatchad changed the title ~~Progress on building~~ Get it building Jan 5, 2023

khatchad added 6 commits January 5, 2023 16:10

Switch to mainline IDE.

8fc937f

Update README.md.

16e1eeb

Fix relative link.

8f048c2

Add anchor.

a1e2d85

Enhance anchor.

015656f

Upgrade to WALA v1.5.9.

9c4d9fb

khatchad marked this pull request as ready for review January 5, 2023 21:49

msridhar self-requested a review January 8, 2023 17:58

msridhar reviewed Jan 8, 2023

View reviewed changes

khatchad added 2 commits January 9, 2023 19:51

Using publishLocalPublicationToMavenLocal in CI.

ebcd51f

Per wala/WALA#1173 (comment), using the `publishLocalPublicationToMavenLocal` task instead of the more obvious `publishToMavenLocal` task.

Use publishLocalPublicationToMavenLocal in docs.

effd187

Per wala/WALA#1173 (comment), usinmg the `publishLocalPublicationToMavenLocal` task instead of the more obvious `publishToMavenLocal` task.

khatchad requested a review from msridhar January 10, 2023 10:28

msridhar approved these changes Jan 10, 2023

View reviewed changes

msridhar merged commit 6c85f99 into wala:master Jan 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get it building #23

Get it building #23

khatchad commented Dec 25, 2022 •

edited

Loading

khatchad commented Jan 5, 2023

khatchad commented Jan 5, 2023

khatchad commented Jan 5, 2023

msridhar left a comment

msridhar Jan 8, 2023

khatchad Jan 9, 2023

msridhar Jan 9, 2023

khatchad Jan 10, 2023

msridhar Jan 10, 2023

khatchad Jan 10, 2023

khatchad Jan 10, 2023

msridhar Jan 10, 2023

khatchad Jan 10, 2023

msridhar left a comment

		1. Build and deploy WALA to your local maven repository. This is necessary because the test JARs are not published on Maven Central: `./gradlew publishToMavenLocal`.
		1. If you run into [this issue](https://github.com/wala/WALA/issues/1173), try: `./gradlew publishToMavenLocal -x signRemotePublication`.

Get it building #23

Get it building #23

Conversation

khatchad commented Dec 25, 2022 • edited Loading

khatchad commented Jan 5, 2023

khatchad commented Jan 5, 2023

khatchad commented Jan 5, 2023

msridhar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msridhar left a comment

Choose a reason for hiding this comment

khatchad commented Dec 25, 2022 •

edited

Loading