Chore: Refactor FilterArray code#6152
Merged
connortsui20 merged 9 commits intodevelopfrom Jan 28, 2026
Merged
Conversation
joseph-isaacs
added
the
action/benchmark-sql
connortsui20
force-pushed
the
ct/remove-old-filter-compute
branch
from
52e8194 to
146bfad
Compare
connortsui20
force-pushed
the
ct/refactor-filter-array
branch
2 times, most recently
from
4527c0e to
dd46879
Compare
connortsui20
force-pushed
the
ct/remove-old-filter-compute
branch
from
146bfad to
02b1cf1
Compare
connortsui20
force-pushed
the
ct/refactor-filter-array
branch
from
dd46879 to
82f0b18
Compare
connortsui20
force-pushed
the
ct/remove-old-filter-compute
branch
from
02b1cf1 to
481ad96
Compare
connortsui20
force-pushed
the
ct/refactor-filter-array
branch
from
82f0b18 to
940e633
Compare
connortsui20
force-pushed
the
ct/refactor-filter-array
branch
from
940e633 to
4fb897b
Compare
connortsui20
added
action/benchmark
github-actions
bot
removed
the
action/benchmark
CodSpeed Performance ReportMerging this PR will degrade performance by 21.18%Comparing
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | bench_many_codes_few_values[1024] |
366.6 µs | 330 µs | +11.07% |
| ⚡ | Simulation | bench_sparse_coverage[0.01] |
409.9 µs | 372.6 µs | +10.01% |
| ⚡ | Simulation | bench_many_codes_few_values[2048] |
369.1 µs | 332.7 µs | +10.96% |
| ⚡ | Simulation | bench_sparse_coverage[0.5] |
365.5 µs | 329 µs | +11.1% |
| ⚡ | Simulation | bench_sparse_coverage[0.1] |
366.8 µs | 330.3 µs | +11.05% |
| ⚡ | Simulation | bench_many_codes_few_values[4096] |
375.2 µs | 338.7 µs | +10.77% |
| ❌ | Simulation | take_map[(0.1, 1.0)] |
3.6 ms | 4.5 ms | -19.22% |
| ❌ | Simulation | take_map[(0.05, 1.0)] |
3.1 ms | 3.9 ms | -21.18% |
Footnotes
-
1323 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Contributor
Benchmarks: Random AccessSummary
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
joseph-isaacs
approved these changes
Jan 28, 2026
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/refactor-filter-array
branch
from
4fb897b to
f6bd017
Compare
connortsui20
added a commit
that referenced
this pull request
Jan 30, 2026
Allows us to filter by a `MaskValues` if we want to, as well as by indices or slices directly. This is just a nice to have for using the code in `vortex-compute` on top of the incoming changes in #6152 Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
AdamGS
pushed a commit
that referenced
this pull request
Feb 2, 2026
Allows us to filter by a `MaskValues` if we want to, as well as by indices or slices directly. This is just a nice to have for using the code in `vortex-compute` on top of the incoming changes in #6152 Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
danking
pushed a commit
that referenced
this pull request
Feb 6, 2026
This is a mostly cosmetic change to remove the old filter compute kernels from the `FilterArray` implementation, placing the code in `vortex-array/src/arrays/filter/execute` instead of dispersed everywhere. The non-cosmetic changes are trivial, just making some things cleaner to understand. This is based on top of #6147, which is also based on top of #6146 --------- Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
danking
pushed a commit
that referenced
this pull request
Feb 6, 2026
Allows us to filter by a `MaskValues` if we want to, as well as by indices or slices directly. This is just a nice to have for using the code in `vortex-compute` on top of the incoming changes in #6152 Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a mostly cosmetic change to remove the old filter compute kernels from the
FilterArrayimplementation, placing the code invortex-array/src/arrays/filter/executeinstead of dispersed everywhere. The non-cosmetic changes are trivial, just making some things cleaner to understand.This is based on top of #6147, which is also based on top of #6146