Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion vortex-array/src/arrays/bool/compute/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

mod cast;
mod fill_null;
pub mod filter;
mod invert;
mod is_constant;
mod is_sorted;
Expand Down
124 changes: 0 additions & 124 deletions vortex-array/src/arrays/decimal/compute/filter.rs

This file was deleted.

1 change: 0 additions & 1 deletion vortex-array/src/arrays/decimal/compute/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
mod between;
mod cast;
mod fill_null;
mod filter;
mod is_constant;
mod is_sorted;
mod min_max;
Expand Down
13 changes: 12 additions & 1 deletion vortex-array/src/arrays/filter/array.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,26 @@ use vortex_mask::Mask;
use crate::ArrayRef;
use crate::stats::ArrayStats;

// TODO(connor): Write docs on why we have this, and what we had in the old world so that the future
// does not repeat the mistakes of the past.
/// A lazy array that represents filtering a child array by a boolean [`Mask`].
///
/// The resulting array contains only the elements where the mask is true.
#[derive(Clone, Debug)]
pub struct FilterArray {
/// The source array being filtered.
pub(super) child: ArrayRef,

/// The boolean mask selecting which elements to keep.
pub(super) mask: Mask,

/// The stats for this array.
pub(super) stats: ArrayStats,
}

impl FilterArray {
pub fn new(array: ArrayRef, mask: Mask) -> Self {
Self::try_new(array, mask).vortex_expect("new FilterArray")
Self::try_new(array, mask).vortex_expect("FilterArray construction failed")
}

pub fn try_new(array: ArrayRef, mask: Mask) -> VortexResult<Self> {
Expand All @@ -29,6 +39,7 @@ impl FilterArray {
array.len(),
mask.len()
);

Ok(Self {
child: array,
mask,
Expand Down
165 changes: 0 additions & 165 deletions vortex-array/src/arrays/filter/execute.rs

This file was deleted.

Loading
Loading