Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restic instructions for Enterprise PKS #1579

Merged
merged 2 commits into from
Jun 14, 2019
Merged

Add restic instructions for Enterprise PKS #1579

merged 2 commits into from
Jun 14, 2019

Conversation

stephendotcarter
Copy link
Contributor

@stephendotcarter stephendotcarter commented Jun 13, 2019

Fixes #1571

Signed-off-by: Stephen Carter carters@vmware.com

Signed-off-by: Stephen Carter <carters@vmware.com>
Copy link
Contributor

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @stephendotcarter! I would recommend making the same change in site/docs/v1.0.0/restic.md as well, so it's immediately reflected in the docs for the latest release. Unfortunately this isn't an automated thing right now.

@skriss
Copy link
Contributor

skriss commented Jun 13, 2019

cc @nrb @carlisia @prydonius

@carlisia
Copy link
Contributor

👍 , great to have this instruction!

Merge pending the addition to the v1.0.0 folder.

Copy link
Contributor

@nrb nrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Agreed with Carlisia, looks good to merge once it's also in the v1.0.0 docs as well.

Signed-off-by: Stephen Carter <carters@vmware.com>
@stephendotcarter
Copy link
Contributor Author

I copied the same changes to v1.0.0 👍

@prydonius prydonius merged commit 3ff95ea into vmware-tanzu:master Jun 14, 2019
jessestuart added a commit to jessestuart/velero that referenced this pull request Jun 18, 2019
* upstream/master: (220 commits)
  Add restic instructions for Enterprise PKS (vmware-tanzu#1579)
  Adding Adnan to the team
  Discontinue use of excerpt separators in blog posts. (vmware-tanzu#1578)
  migrate PV snapshot tests
  migrate more backup action tests, remove obsolete test code (vmware-tanzu#1564)
  hide server commands in velero CLI (vmware-tanzu#1561)
  Fix test comparison
  remove glog (vmware-tanzu#1559)
  move issue-template-gen from docs/ to hack/ (vmware-tanzu#1558)
  update go-plugin to latest for bug fix (vmware-tanzu#1560)
  fix panic when processing DeleteBackupRequest objs without labels (vmware-tanzu#1556)
  Refactoring for backup item action tests (vmware-tanzu#1545)
  Support for multiple AWS profiles (vmware-tanzu#1548)
  add a link of velero plugin for alibabacloud to support-matrix docs
  fixes inlining of command in GCP setup docs (vmware-tanzu#1547)
  Signed-off-by: David Coons <coonsd@oregonstate.edu> (vmware-tanzu#1550)
  Add cmd to list plugins (vmware-tanzu#1535)
  Add ability to use wildcard in includes/excludes
  Initial pkg/backup test refactoring (vmware-tanzu#1532)
  Only run CI when relevant files have changed
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for Enterprise PKS
5 participants