Support for multiple AWS profiles #1548
Conversation
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
pranavgaikwad
force-pushed
the
mulAwsProfiles
branch
from
4a8ccbd to
c177058
Compare
|
Pranav found this solution in reference to the issue I created awhile back: #1368. We are aware it does not completely solve the issue that mine was a duplicate from here: #1064 but it does allow someone using S3 to specify different profiles in a BSL. Please let us know if you have any concerns or feel this should be broadened to solve #1064. |
|
This looks pretty reasonable to me. The one thing we do need to do is add code to use "default" as the profile if no profile is specified, for backwards compatibility. Thanks for the PR! |
|
@skriss This change is already backward compatible. When the config variable is not present, the profile is simply passed as an empty string. AWS SDK then loads |
|
Ah, thanks, didn't realize that. |
|
@nrb @carlisia @prydonius please take a look as well. |
pranavgaikwad
force-pushed
the
mulAwsProfiles
branch
from
a2aa8aa to
c177058
Compare
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
* upstream/master: (220 commits) Add restic instructions for Enterprise PKS (vmware-tanzu#1579) Adding Adnan to the team Discontinue use of excerpt separators in blog posts. (vmware-tanzu#1578) migrate PV snapshot tests migrate more backup action tests, remove obsolete test code (vmware-tanzu#1564) hide server commands in velero CLI (vmware-tanzu#1561) Fix test comparison remove glog (vmware-tanzu#1559) move issue-template-gen from docs/ to hack/ (vmware-tanzu#1558) update go-plugin to latest for bug fix (vmware-tanzu#1560) fix panic when processing DeleteBackupRequest objs without labels (vmware-tanzu#1556) Refactoring for backup item action tests (vmware-tanzu#1545) Support for multiple AWS profiles (vmware-tanzu#1548) add a link of velero plugin for alibabacloud to support-matrix docs fixes inlining of command in GCP setup docs (vmware-tanzu#1547) Signed-off-by: David Coons <coonsd@oregonstate.edu> (vmware-tanzu#1550) Add cmd to list plugins (vmware-tanzu#1535) Add ability to use wildcard in includes/excludes Initial pkg/backup test refactoring (vmware-tanzu#1532) Only run CI when relevant files have changed ...
Currently, velero does not support different credentials for different S3 buckets. The S3 connection established uses
defaultprofile. AWS SDK supports multiple profiles to be used. This change adds support for multiple profiles by introducing a new config variable in backup storage location definition. When a profile is not set explicitly by the user, AWS SDK automatically selects thedefaultprofile making this change not break existing configurations.