fix panic when processing DeleteBackupRequest objs without labels #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skriss
approved these changes
Jun 7, 2019
This fix initialises an empty map if the request object's Labels map is nil, allowing the controller to later add and modify labels on the object. Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
prydonius
force-pushed
the
1546-fix-backup-delete-req-panic
branch
from
1f70c6e to
311b84d
Compare
|
done :) ptal |
|
👍 |
jessestuart
added a commit
to jessestuart/velero
that referenced
this pull request
Jun 18, 2019
* upstream/master: (220 commits) Add restic instructions for Enterprise PKS (vmware-tanzu#1579) Adding Adnan to the team Discontinue use of excerpt separators in blog posts. (vmware-tanzu#1578) migrate PV snapshot tests migrate more backup action tests, remove obsolete test code (vmware-tanzu#1564) hide server commands in velero CLI (vmware-tanzu#1561) Fix test comparison remove glog (vmware-tanzu#1559) move issue-template-gen from docs/ to hack/ (vmware-tanzu#1558) update go-plugin to latest for bug fix (vmware-tanzu#1560) fix panic when processing DeleteBackupRequest objs without labels (vmware-tanzu#1556) Refactoring for backup item action tests (vmware-tanzu#1545) Support for multiple AWS profiles (vmware-tanzu#1548) add a link of velero plugin for alibabacloud to support-matrix docs fixes inlining of command in GCP setup docs (vmware-tanzu#1547) Signed-off-by: David Coons <coonsd@oregonstate.edu> (vmware-tanzu#1550) Add cmd to list plugins (vmware-tanzu#1535) Add ability to use wildcard in includes/excludes Initial pkg/backup test refactoring (vmware-tanzu#1532) Only run CI when relevant files have changed ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix initialises an empty map if the request object's Labels map
is nil, allowing the controller to later add and modify labels on the
object.
fixes #1546
Signed-off-by: Adnan Abdulhussein aadnan@vmware.com