-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHubIdentityProvider and support browser-based auth in the Pinniped Supervisor #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First draft of a GitHubIdentityProvider CRD
…er/controller WIP: Add GitHub upstream observer controller
…er/supervisor-hack-script Add GitHub to Supervisor hack script
…ions Add GitHub IDP validations
…to-github Merge main (at 5fe94c4) into `github_identity_provider`
…ations Polish up GitHub validations
Co-authored-by: Ryan Richard <richardry@vmware.com>
…t and GitHub with an error case Co-authored-by: Ryan Richard <richardry@vmware.com>
Co-authored-by: Ryan Richard <richardry@vmware.com>
…okens Issue and refresh downstream ID tokens derived from a GitHub IDP
mention GitHubIdentityProvider in some more website documentation
… github_upstream_watcher_test
For both GitHubIdentityProvider and OIDCIdentityProvider to make them consistent with each other.
Also renamed an interface function from GetName to GetResourceName. Co-authored-by: Ryan Richard <richardry@vmware.com>
Resolve remaining GitHub todos
joshuatcasey
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature was originally developed on a long-lived feature branch with its own CI pipeline, but now should be ready to merge that whole feature branch to main.
Release note: