Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHubIdentityProvider and support browser-based auth in the Pinniped Supervisor #1978

Merged
merged 110 commits into from
Jun 4, 2024

Conversation

cfryanr
Copy link
Member

@cfryanr cfryanr commented Jun 3, 2024

This feature was originally developed on a long-lived feature branch with its own CI pipeline, but now should be ready to merge that whole feature branch to main.

Release note:

Add GitHubIdentityProvider and support browser-based auth in the Pinniped Supervisor.

joshuatcasey and others added 30 commits April 1, 2024 15:10
First draft of a GitHubIdentityProvider CRD
…er/controller

WIP: Add GitHub upstream observer controller
…er/supervisor-hack-script

Add GitHub to Supervisor hack script
…to-github

Merge main (at 5fe94c4) into `github_identity_provider`
joshuatcasey and others added 21 commits May 23, 2024 12:32
Co-authored-by: Ryan Richard <richardry@vmware.com>
…t and GitHub with an error case

Co-authored-by: Ryan Richard <richardry@vmware.com>
Co-authored-by: Ryan Richard <richardry@vmware.com>
…okens

Issue and refresh downstream ID tokens derived from a GitHub IDP
mention GitHubIdentityProvider in some more website documentation
For both GitHubIdentityProvider and OIDCIdentityProvider to make them
consistent with each other.
Also renamed an interface function from GetName to GetResourceName.

Co-authored-by: Ryan Richard <richardry@vmware.com>
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 72.74336% with 308 lines in your changes missing coverage. Please review.

Project coverage is 30.61%. Comparing base (16c8911) to head (6b64a8a).

Files Patch % Lines
...ioned/typed/idp/v1alpha1/githubidentityprovider.go 0.00% 107 Missing ⚠️
...s/supervisor/idp/v1alpha1/zz_generated.deepcopy.go 63.39% 53 Missing and 3 partials ⚠️
...d/idp/v1alpha1/fake/fake_githubidentityprovider.go 32.39% 46 Missing and 2 partials ⚠️
internal/controller/utils.go 0.00% 27 Missing ⚠️
...vedprovider/resolvedoidc/resolved_oidc_provider.go 4.54% 21 Missing ⚠️
...g/githubupstreamwatcher/github_upstream_watcher.go 97.00% 7 Missing and 3 partials ⚠️
...nalversions/idp/v1alpha1/githubidentityprovider.go 61.90% 6 Missing and 2 partials ⚠️
...sor/listers/idp/v1alpha1/githubidentityprovider.go 65.21% 7 Missing and 1 partial ⚠️
internal/githubclient/githubclient.go 95.80% 4 Missing and 2 partials ⚠️
...rovider/resolvedgithub/resolved_github_provider.go 94.79% 4 Missing and 1 partial ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1978      +/-   ##
==========================================
+ Coverage   29.61%   30.61%   +0.99%     
==========================================
  Files         350      363      +13     
  Lines       58750    60481    +1731     
==========================================
+ Hits        17398    18514    +1116     
- Misses      40834    41432     +598     
- Partials      518      535      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cfryanr cfryanr enabled auto-merge June 4, 2024 16:40
@cfryanr cfryanr merged commit ca9560e into main Jun 4, 2024
45 checks passed
@cfryanr cfryanr deleted the github_identity_provider branch June 21, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants