Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish up GitHub validations #1925

Merged

Conversation

joshuatcasey
Copy link
Member

Polish up GitHub validations

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 38.91%. Comparing base (d0bbfca) to head (14b1b7c).

Files Patch % Lines
...g/githubupstreamwatcher/github_upstream_watcher.go 93.75% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           github_identity_provider    #1925      +/-   ##
============================================================
+ Coverage                     38.86%   38.91%   +0.04%     
============================================================
  Files                           354      354              
  Lines                         45237    45251      +14     
============================================================
+ Hits                          17580    17608      +28     
+ Misses                        27130    27117      -13     
+ Partials                        527      526       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuatcasey joshuatcasey force-pushed the jtc/polish-up-github-validations branch from 6894582 to 14b1b7c Compare April 24, 2024 18:38
Copy link
Member

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminapetersen benjaminapetersen merged commit 8938990 into github_identity_provider Apr 25, 2024
33 checks passed
@benjaminapetersen benjaminapetersen deleted the jtc/polish-up-github-validations branch April 25, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants