Issue and refresh downstream ID tokens derived from a GitHub IDP #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## github_identity_provider #1963 +/- ##
============================================================
+ Coverage 30.14% 30.57% +0.43%
============================================================
Files 358 362 +4
Lines 59869 60335 +466
============================================================
+ Hits 18046 18448 +402
- Misses 41293 41353 +60
- Partials 530 534 +4 ☔ View full report in Codecov by Sentry. |
cfryanr
reviewed
May 21, 2024
internal/federationdomain/endpoints/callback/callback_handler_github_test.go
Outdated
Show resolved
Hide resolved
cfryanr
reviewed
May 21, 2024
internal/federationdomain/resolvedprovider/resolvedgithub/resolved_github_provider.go
Outdated
Show resolved
Hide resolved
cfryanr
reviewed
May 21, 2024
internal/federationdomain/endpoints/callback/callback_handler_test.go
Outdated
Show resolved
Hide resolved
joshuatcasey
force-pushed
the
github-issues-downstream-tokens
branch
3 times, most recently
from
cd5591d
to
1289fa8
Compare
cfryanr
reviewed
May 22, 2024
internal/federationdomain/resolvedprovider/resolvedgithub/resolved_github_provider.go
Show resolved
Hide resolved
Co-authored-by: Ryan Richard <richardry@vmware.com>
ALso fixed some of the GitHub test helpers
Co-authored-by: Ryan Richard <richardry@vmware.com>
Co-authored-by: Ryan Richard <richardry@vmware.com>
Co-authored-by: Joshua Casey <joshuatcasey@gmail.com>
Co-authored-by: Ryan Richard <richardry@vmware.com>
Also: - fix github teams query: fix bug and sort/unique the results - add IDP display name to github downstream subject - fix error types returned by LoginFromCallback - add trace logs to github API results - update e2e test - implement placeholder version of refresh for github
Co-authored-by: Joshua Casey <joshuatcasey@gmail.com>
Co-authored-by: Joshua Casey <joshuatcasey@gmail.com>
Co-authored-by: Joshua Casey <joshuatcasey@gmail.com>
joshuatcasey
force-pushed
the
github-issues-downstream-tokens
branch
from
ac6d56f
to
bb1737d
Compare
joshuatcasey
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## github_identity_provider #1963 +/- ##
============================================================
+ Coverage 30.14% 30.60% +0.46%
============================================================
Files 358 362 +4
Lines 59869 60383 +514
============================================================
+ Hits 18046 18481 +435
- Misses 41293 41368 +75
- Partials 530 534 +4 ☔ View full report in Codecov by Sentry. |
joshuatcasey
changed the title
Co-authored-by: Ryan Richard <richardry@vmware.com>
…t and GitHub with an error case Co-authored-by: Ryan Richard <richardry@vmware.com>
Co-authored-by: Ryan Richard <richardry@vmware.com>
cfryanr
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Supervisor will now issue downstream tokens when logging in with GitHub as an identity provider. Will check the user's organization and team membership and ensure that the user meets the login policy specified on the GitHub IDP CR.
Refreshing a GitHub-derived identity is virtually identical to logging in, so that was implemented as well.