Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usage lib get version another way #3735

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

simon-mo
Copy link
Collaborator

This approach is compatible with our docker installation.

Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also hit this in our docker build :)

@simon-mo simon-mo merged commit 8b2d3cb into vllm-project:main Mar 29, 2024
34 checks passed
xjpang pushed a commit to xjpang/vllm that referenced this pull request Mar 31, 2024
njhill added a commit to njhill/vllm that referenced this pull request Apr 2, 2024
Using importlib version() function doesn't work in the docker image.

Introduced in vllm-project#3634

Equivalent fix to vllm-project#3735
Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants