[BugFix] Use different mechanism to get vllm version in is_cpu()
#3804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using importlib version() function doesn't work in the docker image. Introduced in vllm-project#3634 Equivalent fix to vllm-project#3735
|
I guess this doesn't seem to work for detecting that it's a CPU build. |
|
Have reworked the fix - this works because the CPU image is currently built via |
WoosukKwon
approved these changes
Apr 3, 2024
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
Apr 22, 2024
Temirulan
pushed a commit
to Temirulan/vllm-whisper
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
importlib.metadata.version()function doesn't work in the non-CPU docker image.Introduced in #3634
Equivalent fix to #3735